From 9d8a70c809ad00c500f83046606561b19c627eb8 Mon Sep 17 00:00:00 2001 From: Andrew Casey Date: Tue, 28 Apr 2020 11:12:38 -0700 Subject: [PATCH] Include a stack in InitializationFailedResponse (#38223) * Include a stack in InitializationFailedResponse * Update API baselines --- src/jsTyping/types.ts | 1 + src/typingsInstaller/nodeTypingsInstaller.ts | 3 ++- tests/baselines/reference/api/tsserverlibrary.d.ts | 1 + tests/baselines/reference/api/typescript.d.ts | 1 + 4 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/jsTyping/types.ts b/src/jsTyping/types.ts index 6da6200c2c0..34f69d0d624 100644 --- a/src/jsTyping/types.ts +++ b/src/jsTyping/types.ts @@ -51,6 +51,7 @@ declare namespace ts.server { export interface InitializationFailedResponse extends TypingInstallerResponse { readonly kind: EventInitializationFailed; readonly message: string; + readonly stack?: string; } export interface ProjectResponse extends TypingInstallerResponse { diff --git a/src/typingsInstaller/nodeTypingsInstaller.ts b/src/typingsInstaller/nodeTypingsInstaller.ts index ab050fd60bf..a59e8ec4b9d 100644 --- a/src/typingsInstaller/nodeTypingsInstaller.ts +++ b/src/typingsInstaller/nodeTypingsInstaller.ts @@ -122,7 +122,8 @@ namespace ts.server.typingsInstaller { // store error info to report it later when it is known that server is already listening to events from typings installer this.delayedInitializationError = { kind: "event::initializationFailed", - message: (e).message + message: (e).message, + stack: (e).stack, }; } diff --git a/tests/baselines/reference/api/tsserverlibrary.d.ts b/tests/baselines/reference/api/tsserverlibrary.d.ts index 27bd23efaa3..22d6234d13d 100644 --- a/tests/baselines/reference/api/tsserverlibrary.d.ts +++ b/tests/baselines/reference/api/tsserverlibrary.d.ts @@ -4960,6 +4960,7 @@ declare namespace ts.server { interface InitializationFailedResponse extends TypingInstallerResponse { readonly kind: EventInitializationFailed; readonly message: string; + readonly stack?: string; } interface ProjectResponse extends TypingInstallerResponse { readonly projectName: string; diff --git a/tests/baselines/reference/api/typescript.d.ts b/tests/baselines/reference/api/typescript.d.ts index 068380e2ad5..4e4746560ed 100644 --- a/tests/baselines/reference/api/typescript.d.ts +++ b/tests/baselines/reference/api/typescript.d.ts @@ -4960,6 +4960,7 @@ declare namespace ts.server { interface InitializationFailedResponse extends TypingInstallerResponse { readonly kind: EventInitializationFailed; readonly message: string; + readonly stack?: string; } interface ProjectResponse extends TypingInstallerResponse { readonly projectName: string;