From a70b79072b8fae40f6033f9f2958004c09ec98c6 Mon Sep 17 00:00:00 2001 From: Andy Hanson Date: Mon, 1 May 2017 07:54:41 -0700 Subject: [PATCH 1/2] importTracker: Fix error for undefined importClause --- src/services/importTracker.ts | 4 ++++ tests/cases/fourslash/findAllRefsNoImportClause.ts | 11 +++++++++++ 2 files changed, 15 insertions(+) create mode 100644 tests/cases/fourslash/findAllRefsNoImportClause.ts diff --git a/src/services/importTracker.ts b/src/services/importTracker.ts index 0108d830dd1..c94d5cc3143 100644 --- a/src/services/importTracker.ts +++ b/src/services/importTracker.ts @@ -212,6 +212,10 @@ namespace ts.FindAllReferences { return; } + if (!decl.importClause) { + return; + } + const { importClause } = decl; const { namedBindings } = importClause; diff --git a/tests/cases/fourslash/findAllRefsNoImportClause.ts b/tests/cases/fourslash/findAllRefsNoImportClause.ts new file mode 100644 index 00000000000..ee9fb7a7313 --- /dev/null +++ b/tests/cases/fourslash/findAllRefsNoImportClause.ts @@ -0,0 +1,11 @@ +/// + +// https://github.com/Microsoft/TypeScript/issues/15452 + +// @Filename: /a.ts +////export const [|x|] = 0; + +// @Filename: /b.ts +////import "./a"; + +verify.singleReferenceGroup("const x: 0"); From 969da26d455cb254171c2b756afc1d707a7df28a Mon Sep 17 00:00:00 2001 From: Andy Hanson Date: Mon, 1 May 2017 09:03:12 -0700 Subject: [PATCH 2/2] Add isWriteAccess --- tests/cases/fourslash/findAllRefsNoImportClause.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/cases/fourslash/findAllRefsNoImportClause.ts b/tests/cases/fourslash/findAllRefsNoImportClause.ts index ee9fb7a7313..b98f5d02d01 100644 --- a/tests/cases/fourslash/findAllRefsNoImportClause.ts +++ b/tests/cases/fourslash/findAllRefsNoImportClause.ts @@ -3,7 +3,7 @@ // https://github.com/Microsoft/TypeScript/issues/15452 // @Filename: /a.ts -////export const [|x|] = 0; +////export const [|{| "isWriteAccess": true, "isDefinition": true |}x|] = 0; // @Filename: /b.ts ////import "./a";