From 9bc0d33512675f5f45d1ac31d024f28c0c37ddbf Mon Sep 17 00:00:00 2001 From: Andrew Casey Date: Fri, 26 Jan 2018 11:12:34 -0800 Subject: [PATCH] Move bug URLs into assert messages --- src/compiler/utilities.ts | 9 ++++----- src/services/refactors/extractSymbol.ts | 6 ++---- 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/src/compiler/utilities.ts b/src/compiler/utilities.ts index b6700d21a70..f2874b6b665 100644 --- a/src/compiler/utilities.ts +++ b/src/compiler/utilities.ts @@ -687,14 +687,13 @@ namespace ts { : skipTrivia(sourceFile.text, errorNode.pos); // These asserts should all be satisfied for a properly constructed `errorNode`. - // Upstream from https://github.com/Microsoft/TypeScript/issues/20809. if (isMissing) { - Debug.assert(pos === errorNode.pos); - Debug.assert(pos === errorNode.end); + Debug.assert(pos === errorNode.pos, "This failure could trigger https://github.com/Microsoft/TypeScript/issues/20809"); + Debug.assert(pos === errorNode.end, "This failure could trigger https://github.com/Microsoft/TypeScript/issues/20809"); } else { - Debug.assert(pos >= errorNode.pos); - Debug.assert(pos <= errorNode.end); + Debug.assert(pos >= errorNode.pos, "This failure could trigger https://github.com/Microsoft/TypeScript/issues/20809"); + Debug.assert(pos <= errorNode.end, "This failure could trigger https://github.com/Microsoft/TypeScript/issues/20809"); } return createTextSpanFromBounds(pos, errorNode.end); diff --git a/src/services/refactors/extractSymbol.ts b/src/services/refactors/extractSymbol.ts index 9b397584fed..74a944077ec 100644 --- a/src/services/refactors/extractSymbol.ts +++ b/src/services/refactors/extractSymbol.ts @@ -336,13 +336,11 @@ namespace ts.refactor.extractSymbol { Return = 1 << 2 } - // This assert is upstream from https://github.com/Microsoft/TypeScript/issues/20809. // We believe it's true because the node is from the (unmodified) tree. - Debug.assert(nodeToCheck.pos <= nodeToCheck.end); + Debug.assert(nodeToCheck.pos <= nodeToCheck.end, "This failure could trigger https://github.com/Microsoft/TypeScript/issues/20809"); - // This assert is upstream from https://github.com/Microsoft/TypeScript/issues/20809. // For understanding how skipTrivia functioned: - Debug.assert(!positionIsSynthesized(nodeToCheck.pos)); + Debug.assert(!positionIsSynthesized(nodeToCheck.pos), "This failure could trigger https://github.com/Microsoft/TypeScript/issues/20809"); if (!isStatement(nodeToCheck) && !(isExpressionNode(nodeToCheck) && isExtractableExpression(nodeToCheck))) { return [createDiagnosticForNode(nodeToCheck, Messages.statementOrExpressionExpected)];