From 9a957e7b9cecfc0acd7c8ce4c5808b005c6fb0de Mon Sep 17 00:00:00 2001 From: Ryan Cavanaugh Date: Wed, 2 Dec 2020 11:47:32 -0800 Subject: [PATCH] Remove incorrect assert that triggers crash on completions of globalThis (#40278) Fixes #39338 --- src/services/symbolDisplay.ts | 2 -- tests/cases/fourslash/globalThisCompletion.ts | 18 ++++++++++++++++++ 2 files changed, 18 insertions(+), 2 deletions(-) create mode 100644 tests/cases/fourslash/globalThisCompletion.ts diff --git a/src/services/symbolDisplay.ts b/src/services/symbolDisplay.ts index 2a2a1f846d5..4acba52253a 100644 --- a/src/services/symbolDisplay.ts +++ b/src/services/symbolDisplay.ts @@ -71,8 +71,6 @@ namespace ts.SymbolDisplay { if (rootSymbolFlags & (SymbolFlags.PropertyOrAccessor | SymbolFlags.Variable)) { return ScriptElementKind.memberVariableElement; } - // May be a Function if this was from `typeof N` with `namespace N { function f();. }`. - Debug.assert(!!(rootSymbolFlags & (SymbolFlags.Method | SymbolFlags.Function))); }); if (!unionPropertyKind) { // If this was union of all methods, diff --git a/tests/cases/fourslash/globalThisCompletion.ts b/tests/cases/fourslash/globalThisCompletion.ts new file mode 100644 index 00000000000..0d5530da260 --- /dev/null +++ b/tests/cases/fourslash/globalThisCompletion.ts @@ -0,0 +1,18 @@ +/// + +// @allowJs: true +// @target: esnext + +// @Filename: test.js +//// (typeof foo !== "undefined" +//// ? foo +//// : {} +//// )./**/; + +// @Filename: someLib.d.ts +//// declare var foo: typeof globalThis; + +goTo.marker(); +verify.completions({ + marker: "" +});