From 98ed0eb94c784221f77b51b140b85ed64d04076e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Maria=20Jos=C3=A9=20Solano?= Date: Fri, 26 May 2023 10:06:12 -0700 Subject: [PATCH] Localize refactor descriptions (#54379) --- src/services/refactors/addOrRemoveBracesToArrowFunction.ts | 6 +++--- src/services/refactors/convertExport.ts | 6 +++--- src/services/refactors/convertImport.ts | 6 +++--- .../refactors/convertOverloadListToSingleSignature.ts | 3 ++- src/services/refactors/generateGetAccessorAndSetAccessor.ts | 3 ++- src/services/refactors/inferFunctionReturnType.ts | 2 +- 6 files changed, 14 insertions(+), 12 deletions(-) diff --git a/src/services/refactors/addOrRemoveBracesToArrowFunction.ts b/src/services/refactors/addOrRemoveBracesToArrowFunction.ts index 930a1b42d44..40640dc73ef 100644 --- a/src/services/refactors/addOrRemoveBracesToArrowFunction.ts +++ b/src/services/refactors/addOrRemoveBracesToArrowFunction.ts @@ -35,16 +35,16 @@ import { } from "../_namespaces/ts.refactor"; const refactorName = "Add or remove braces in an arrow function"; -const refactorDescription = Diagnostics.Add_or_remove_braces_in_an_arrow_function.message; +const refactorDescription = getLocaleSpecificMessage(Diagnostics.Add_or_remove_braces_in_an_arrow_function); const addBracesAction = { name: "Add braces to arrow function", - description: Diagnostics.Add_braces_to_arrow_function.message, + description: getLocaleSpecificMessage(Diagnostics.Add_braces_to_arrow_function), kind: "refactor.rewrite.arrow.braces.add", }; const removeBracesAction = { name: "Remove braces from arrow function", - description: Diagnostics.Remove_braces_from_arrow_function.message, + description: getLocaleSpecificMessage(Diagnostics.Remove_braces_from_arrow_function), kind: "refactor.rewrite.arrow.braces.remove" }; registerRefactor(refactorName, { diff --git a/src/services/refactors/convertExport.ts b/src/services/refactors/convertExport.ts index 3760cd8b313..0509e1e0c51 100644 --- a/src/services/refactors/convertExport.ts +++ b/src/services/refactors/convertExport.ts @@ -61,12 +61,12 @@ const refactorName = "Convert export"; const defaultToNamedAction = { name: "Convert default export to named export", - description: Diagnostics.Convert_default_export_to_named_export.message, + description: getLocaleSpecificMessage(Diagnostics.Convert_default_export_to_named_export), kind: "refactor.rewrite.export.named" }; const namedToDefaultAction = { name: "Convert named export to default export", - description: Diagnostics.Convert_named_export_to_default_export.message, + description: getLocaleSpecificMessage(Diagnostics.Convert_named_export_to_default_export), kind: "refactor.rewrite.export.default" }; @@ -86,7 +86,7 @@ registerRefactor(refactorName, { if (context.preferences.provideRefactorNotApplicableReason) { return [ - { name: refactorName, description: Diagnostics.Convert_default_export_to_named_export.message, actions: [ + { name: refactorName, description: getLocaleSpecificMessage(Diagnostics.Convert_default_export_to_named_export), actions: [ { ...defaultToNamedAction, notApplicableReason: info.error }, { ...namedToDefaultAction, notApplicableReason: info.error }, ]} diff --git a/src/services/refactors/convertImport.ts b/src/services/refactors/convertImport.ts index da3a66107de..2f177be0770 100644 --- a/src/services/refactors/convertImport.ts +++ b/src/services/refactors/convertImport.ts @@ -55,17 +55,17 @@ const refactorName = "Convert import"; const actions = { [ImportKind.Named]: { name: "Convert namespace import to named imports", - description: Diagnostics.Convert_namespace_import_to_named_imports.message, + description: getLocaleSpecificMessage(Diagnostics.Convert_namespace_import_to_named_imports), kind: "refactor.rewrite.import.named", }, [ImportKind.Namespace]: { name: "Convert named imports to namespace import", - description: Diagnostics.Convert_named_imports_to_namespace_import.message, + description: getLocaleSpecificMessage(Diagnostics.Convert_named_imports_to_namespace_import), kind: "refactor.rewrite.import.namespace", }, [ImportKind.Default]: { name: "Convert named imports to default import", - description: Diagnostics.Convert_named_imports_to_default_import.message, + description: getLocaleSpecificMessage(Diagnostics.Convert_named_imports_to_default_import), kind: "refactor.rewrite.import.default", }, }; diff --git a/src/services/refactors/convertOverloadListToSingleSignature.ts b/src/services/refactors/convertOverloadListToSingleSignature.ts index c0ad2970a61..1a54a297eb7 100644 --- a/src/services/refactors/convertOverloadListToSingleSignature.ts +++ b/src/services/refactors/convertOverloadListToSingleSignature.ts @@ -12,6 +12,7 @@ import { factory, findAncestor, FunctionDeclaration, + getLocaleSpecificMessage, getSourceFileOfNode, getSyntheticLeadingComments, getTokenAtPosition, @@ -42,7 +43,7 @@ import { import { registerRefactor } from "../_namespaces/ts.refactor"; const refactorName = "Convert overload list to single signature"; -const refactorDescription = Diagnostics.Convert_overload_list_to_single_signature.message; +const refactorDescription = getLocaleSpecificMessage(Diagnostics.Convert_overload_list_to_single_signature); const functionOverloadAction = { name: refactorName, diff --git a/src/services/refactors/generateGetAccessorAndSetAccessor.ts b/src/services/refactors/generateGetAccessorAndSetAccessor.ts index 2982cacd8af..86ca118d2c9 100644 --- a/src/services/refactors/generateGetAccessorAndSetAccessor.ts +++ b/src/services/refactors/generateGetAccessorAndSetAccessor.ts @@ -4,6 +4,7 @@ import { Debug, Diagnostics, emptyArray, + getLocaleSpecificMessage, getRenameLocation, isIdentifier, isParameter, @@ -15,7 +16,7 @@ import { } from "../_namespaces/ts.refactor"; const actionName = "Generate 'get' and 'set' accessors"; -const actionDescription = Diagnostics.Generate_get_and_set_accessors.message; +const actionDescription = getLocaleSpecificMessage(Diagnostics.Generate_get_and_set_accessors); const generateGetSetAction = { name: actionName, diff --git a/src/services/refactors/inferFunctionReturnType.ts b/src/services/refactors/inferFunctionReturnType.ts index ccce34a8a14..1e54133c1ff 100644 --- a/src/services/refactors/inferFunctionReturnType.ts +++ b/src/services/refactors/inferFunctionReturnType.ts @@ -35,7 +35,7 @@ import { } from "../_namespaces/ts.refactor"; const refactorName = "Infer function return type"; -const refactorDescription = Diagnostics.Infer_function_return_type.message; +const refactorDescription = getLocaleSpecificMessage(Diagnostics.Infer_function_return_type); const inferReturnTypeAction = { name: refactorName,