From 9885e59e426be4b928d2e6bbd678f6d1648e9aa1 Mon Sep 17 00:00:00 2001
From: Mohamed Hegazy <mhegazy@microsoft.com>
Date: Thu, 25 Sep 2014 12:45:35 -0700
Subject: [PATCH] respond to code review comments

---
 src/services/services.ts | 42 +++++++++++++++++++++-------------------
 1 file changed, 22 insertions(+), 20 deletions(-)

diff --git a/src/services/services.ts b/src/services/services.ts
index d2d3e56a1d0..e701be161a5 100644
--- a/src/services/services.ts
+++ b/src/services/services.ts
@@ -3799,27 +3799,29 @@ module ts {
             forEach(signatureHelpItems.items, signature => {
                 var signatureInfoString = signature.prefix;
 
-                var paramters: FormalParameterInfo[] = [];
-                for (var i = 0, n = signature.parameters.length; i < n; i++) {
-                    var paramter = signature.parameters[i];
+                var parameters: FormalParameterInfo[] = [];
+                if (signature.parameters) {
+                    for (var i = 0, n = signature.parameters.length; i < n; i++) {
+                        var parameter = signature.parameters[i];
 
-                    // add the parameter to the string
-                    if (i) {
-                        signatureInfoString += signature.separator;
+                        // add the parameter to the string
+                        if (i) {
+                            signatureInfoString += signature.separator;
+                        }
+
+                        var start = signatureInfoString.length;
+                        signatureInfoString += parameter.display;
+                        var end = signatureInfoString.length - 1;
+
+                        // add the parameter to the list
+                        parameters.push({
+                            name: parameter.name,
+                            isVariable: i == n - 1 && signature.isVariadic,
+                            docComment: parameter.documentation,
+                            minChar: start,
+                            limChar: end
+                        });
                     }
-
-                    var start = signatureInfoString.length;
-                    signatureInfoString += paramter.display;
-                    var end = signatureInfoString.length - 1;
-
-                    // add the parameter to the list
-                    paramters.push({
-                        name: paramter.name,
-                        isVariable: i == n -1 && signature.isVariadic,
-                        docComment: paramter.documentation,
-                        minChar: start,
-                        limChar: end
-                    });
                 }
 
                 signatureInfoString += signature.suffix;
@@ -3827,7 +3829,7 @@ module ts {
                 formalSignatures.push({
                     signatureInfo: signatureInfoString,
                     docComment: signature.documentation,
-                    parameters: paramters,
+                    parameters: parameters,
                     typeParameters: [],
                     docComments: signature.documentation
                 });