Address code review

This commit is contained in:
Yui T 2014-11-18 16:32:18 -08:00
parent 1d78406bf8
commit 970aac6458
6 changed files with 6 additions and 6 deletions

View File

@ -3564,7 +3564,7 @@ module ts {
return {
emitResultStatus,
errors: diagnostics,
diagnostics,
sourceMaps: sourceMapDataList
};
}

View File

@ -368,7 +368,7 @@ module ts {
else {
var emitStart = new Date().getTime();
var emitOutput = checker.invokeEmitter();
var emitErrors = emitOutput.errors;
var emitErrors = emitOutput.diagnostics;
exitStatus = emitOutput.emitResultStatus;
var reportStart = new Date().getTime();
errors = concatenate(errors, emitErrors);

View File

@ -700,7 +700,7 @@ module ts {
export interface EmitResult {
emitResultStatus: EmitReturnStatus;
errors: Diagnostic[];
diagnostics: Diagnostic[];
sourceMaps: SourceMapData[]; // Array of sourceMapData if compiler emitted sourcemaps
}

View File

@ -810,7 +810,7 @@ module Harness {
}
var errors: HarnessDiagnostic[] = [];
program.getDiagnostics().concat(checker.getDiagnostics()).concat(emitResult ? emitResult.errors : []).forEach(err => {
program.getDiagnostics().concat(checker.getDiagnostics()).concat(emitResult ? emitResult.diagnostics : []).forEach(err => {
// TODO: new compiler formats errors after this point to add . and newlines so we'll just do it manually for now
errors.push(getMinimalDiagnostic(err));
});

View File

@ -132,7 +132,7 @@ class ProjectRunner extends RunnerBase {
var checker = program.getTypeChecker(/*fullTypeCheck*/ true);
errors = checker.getDiagnostics();
var emitResult = checker.invokeEmitter();
errors = ts.concatenate(errors, emitResult.errors);
errors = ts.concatenate(errors, emitResult.diagnostics);
sourceMapData = emitResult.sourceMaps;
// Clean up source map data that will be used in baselining

View File

@ -2291,7 +2291,7 @@ module ts {
// Get emitter-diagnostics requires calling TypeChecker.emitFiles so we have to define CompilerHost.writer which does nothing because emitFiles function has side effects defined by CompilerHost.writer
var savedWriter = writer;
writer = (filename: string, data: string, writeByteOrderMark: boolean) => { };
allDiagnostics = allDiagnostics.concat(checker.invokeEmitter(targetSourceFile).errors);
allDiagnostics = allDiagnostics.concat(checker.invokeEmitter(targetSourceFile).diagnostics);
writer = savedWriter;
}
return allDiagnostics