microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-02-22 16:52:14 -06:00
Code Issues Packages Projects Releases 212 Wiki Activity

Don't implicit-any diagnostic for json module

Browse Source
This commit is contained in:
Andy Hanson 2018-09-26 13:50:37 -07:00
parent 98ec1e8730
commit 96f9e076f8
2 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/compiler/checker.ts
View File

@ -2241,7 +2241,7 @@ namespace ts {
const sourceFile = resolvedModule && !resolutionDiagnostic && host.getSourceFile(resolvedModule.resolvedFileName);
if (sourceFile) {
if (sourceFile.symbol) {
if (resolvedModule.isExternalLibraryImport && !extensionIsTS(resolvedModule.extension)) {
if (resolvedModule.isExternalLibraryImport && !resolutionExtensionIsTSOrJson(resolvedModule.extension)) {
errorOnImplicitAnyModule(/*isError*/ false, errorNode, resolvedModule, moduleReference);
}
// merged symbol is module declaration symbol combined with all augmentations

16
tests/cases/fourslash/codeFixCannotFindModule_suggestion_falsePositive.ts Normal file
View File

@ -0,0 +1,16 @@
/// <reference path='fourslash.ts' />
// @moduleResolution: node
// @resolveJsonModule: true
// @strict: true
// @Filename: /node_modules/foo/bar.json
////export const x = 0;
// @Filename: /a.ts
////import abs = require([|"foo/bar.json"|]);
////abs;
verify.noErrors();
goTo.file("/a.ts");
verify.getSuggestionDiagnostics([]);