From 965d43c6a553aaeb7c849baa9410566974dfd178 Mon Sep 17 00:00:00 2001 From: Arthur Ozga Date: Sun, 12 Mar 2017 18:35:48 -0700 Subject: [PATCH] Print new nodes in correct order --- src/services/codefixes/helpers.ts | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/services/codefixes/helpers.ts b/src/services/codefixes/helpers.ts index 27195ac0be0..bbbe14ab337 100644 --- a/src/services/codefixes/helpers.ts +++ b/src/services/codefixes/helpers.ts @@ -10,8 +10,8 @@ namespace ts.codefix { const changeTracker = textChanges.ChangeTracker.fromCodeFixContext(context); - for (let i = newNodes.length - 1; i >= 0; i--) { - changeTracker.insertNodeAfter(sourceFile, insertAfter, newNodes[i], { insertTrailingNewLine: true }); + for (const newNode of newNodes) { + changeTracker.insertNodeAfter(sourceFile, insertAfter, newNode, { insertTrailingNewLine: true }); } return changeTracker.getChanges(); } @@ -52,7 +52,8 @@ namespace ts.codefix { const declaration = declarations[0] as Declaration; const name = declaration.name ? declaration.name.getText() : undefined; - const modifiers = [createVisibilityModifier(getModifierFlags(declaration))]; + const visibilityModifier = createVisibilityModifier(getModifierFlags(declaration)); + const modifiers = visibilityModifier ? [visibilityModifier] : undefined; const type = checker.getTypeOfSymbolAtLocation(symbol, enclosingDeclaration); switch (declaration.kind) { @@ -64,7 +65,7 @@ namespace ts.codefix { // TODO: add modifiers. const property = createProperty( /*decorators*/undefined - , /*modifiers*/ undefined + , modifiers , name , /*questionToken*/ undefined , typeNode