diff --git a/src/services/codefixes/inferFromUsage.ts b/src/services/codefixes/inferFromUsage.ts index 292b92dbd32..f7b5edc5ca7 100644 --- a/src/services/codefixes/inferFromUsage.ts +++ b/src/services/codefixes/inferFromUsage.ts @@ -501,7 +501,7 @@ namespace ts.codefix { return; } else { - const indexType = checker.getTypeAtLocation(parent); + const indexType = checker.getTypeAtLocation(parent.argumentExpression); const indexUsageContext = {}; inferTypeFromContext(parent, checker, indexUsageContext); if (indexType.flags & TypeFlags.NumberLike) { @@ -562,11 +562,11 @@ namespace ts.codefix { } if (usageContext.numberIndexContext) { - numberIndexInfo = checker.createIndexInfo(getTypeFromUsageContext(usageContext.numberIndexContext, checker)!, /*isReadonly*/ false); // TODO: GH#18217 + numberIndexInfo = checker.createIndexInfo(getTypeFromUsageContext(usageContext.numberIndexContext, checker) || checker.getAnyType(), /*isReadonly*/ false); } if (usageContext.stringIndexContext) { - stringIndexInfo = checker.createIndexInfo(getTypeFromUsageContext(usageContext.stringIndexContext, checker)!, /*isReadonly*/ false); + stringIndexInfo = checker.createIndexInfo(getTypeFromUsageContext(usageContext.stringIndexContext, checker) || checker.getAnyType(), /*isReadonly*/ false); } return checker.createAnonymousType(/*symbol*/ undefined!, members, callSignatures, constructSignatures, stringIndexInfo, numberIndexInfo); // TODO: GH#18217 diff --git a/tests/cases/fourslash/codeFixInferFromUsageNumberIndexSignature.ts b/tests/cases/fourslash/codeFixInferFromUsageNumberIndexSignature.ts new file mode 100644 index 00000000000..cf031bd017f --- /dev/null +++ b/tests/cases/fourslash/codeFixInferFromUsageNumberIndexSignature.ts @@ -0,0 +1,8 @@ +/// + +// @noImplicitAny: true +////function f([|a |]) { +//// return a[0] + 1; +////} + +verify.rangeAfterCodeFix("a: { [x: number]: number; }",/*includeWhiteSpace*/ undefined, /*errorCode*/ undefined, 0); diff --git a/tests/cases/fourslash/codeFixInferFromUsageStringIndexSignature.ts b/tests/cases/fourslash/codeFixInferFromUsageStringIndexSignature.ts new file mode 100644 index 00000000000..765f788e054 --- /dev/null +++ b/tests/cases/fourslash/codeFixInferFromUsageStringIndexSignature.ts @@ -0,0 +1,8 @@ +/// + +// @noImplicitAny: true +////function f([|a |]) { +//// return a['hi']; +////} + +verify.rangeAfterCodeFix("a: { [x: string]: any; }",/*includeWhiteSpace*/ undefined, /*errorCode*/ undefined, 0); diff --git a/tests/cases/fourslash/typeToStringCrashInCodeFix.ts b/tests/cases/fourslash/typeToStringCrashInCodeFix.ts index 261f0824406..5201a6b77fb 100644 --- a/tests/cases/fourslash/typeToStringCrashInCodeFix.ts +++ b/tests/cases/fourslash/typeToStringCrashInCodeFix.ts @@ -1,6 +1,6 @@ /// // @noImplicitAny: true -//// function f(y, z = { p: y[ +//// function f([|y |], z = { p: y[ -verify.not.codeFixAvailable(); +verify.rangeAfterCodeFix("y: { [x: string]: any; }",/*includeWhiteSpace*/ undefined, /*errorCode*/ undefined, 0);