From 937a7e5190ea00474d56a6b136ecadadedc3b3cd Mon Sep 17 00:00:00 2001 From: Paul van Brenk Date: Wed, 26 Nov 2014 11:34:36 -0800 Subject: [PATCH 1/2] Make sure we return a valid string to prevent a crash in the navigate to implementation in VS. --- src/services/services.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/services/services.ts b/src/services/services.ts index a83fb7e0e75..ec48897dfe8 100644 --- a/src/services/services.ts +++ b/src/services/services.ts @@ -2730,8 +2730,8 @@ module ts { case SyntaxKind.TypeParameter: return ScriptElementKind.typeParameterElement; case SyntaxKind.EnumMember: return ScriptElementKind.variableElement; case SyntaxKind.Parameter: return (node.flags & NodeFlags.AccessibilityModifier) ? ScriptElementKind.memberVariableElement : ScriptElementKind.parameterElement; - return ScriptElementKind.unknown; } + return ScriptElementKind.unknown; } function getSymbolModifiers(symbol: Symbol): string { From a09ba2fbd20703a28a863d6f0205a7ab87d1c385 Mon Sep 17 00:00:00 2001 From: Paul van Brenk Date: Wed, 26 Nov 2014 11:45:33 -0800 Subject: [PATCH 2/2] Update LKG --- bin/typescriptServices.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/typescriptServices.js b/bin/typescriptServices.js index c3ca7ac4975..8d600bf6048 100644 --- a/bin/typescriptServices.js +++ b/bin/typescriptServices.js @@ -33748,8 +33748,8 @@ var ts; return ScriptElementKind.variableElement; case 118 /* Parameter */: return (node.flags & ts.NodeFlags.AccessibilityModifier) ? ScriptElementKind.memberVariableElement : ScriptElementKind.parameterElement; - return ScriptElementKind.unknown; } + return ScriptElementKind.unknown; } function getSymbolModifiers(symbol) { return symbol && symbol.declarations && symbol.declarations.length > 0 ? getNodeModifiers(symbol.declarations[0]) : ScriptElementKindModifier.none;