microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-05-15 12:51:30 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

Filter nullables after lifting union over spread

Browse Source 
Previously, null/undefined were removed upfront, which is incorrect. Now
nullable types are removed with other non-primitives after union is
lifted over spread. This produces unions, which are larger, but more correct.
This commit is contained in:
Nathan Shively-Sanders
2017-06-06 14:11:01 -07:00
parent ea830d4fad
commit 93465bdae2
1 changed files with 0 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/compiler/checker.ts
View File

@@ -7632,11 +7632,9 @@ namespace ts {
if (left.flags & TypeFlags.Any || right.flags & TypeFlags.Any) {
return anyType;
}
left = filterType(left, t => !(t.flags & TypeFlags.Nullable));
if (left.flags & TypeFlags.Never) {
return right;
}
right = filterType(right, t => !(t.flags & TypeFlags.Nullable));
if (right.flags & TypeFlags.Never) {
return left;
}