Address code review

This commit is contained in:
Yui T
2015-03-16 15:41:51 -07:00
parent 88933d54cc
commit 91c5bae6e5
14 changed files with 134 additions and 39 deletions

View File

@@ -4511,50 +4511,26 @@ module ts {
return emitPinnedOrTripleSlashComments(member);
}
}
if (member.kind === SyntaxKind.MethodDeclaration || node.kind === SyntaxKind.MethodSignature || member.kind === SyntaxKind.GetAccessor || member.kind === SyntaxKind.SetAccessor) {
writeLine();
emitLeadingComments(member);
emitStart(member);
if (member.flags & NodeFlags.Static) {
write("static ");
}
if (member.kind === SyntaxKind.GetAccessor) {
write("get ");
}
else if (member.kind === SyntaxKind.SetAccessor) {
write("set ");
}
emit((<MethodDeclaration>member).name);
emitSignatureAndBody(<MethodDeclaration>member);
emitEnd(member);
emitTrailingComments(member);
}
else if (member.kind === SyntaxKind.GetAccessor || member.kind === SyntaxKind.SetAccessor) {
var accessors = getAllAccessorDeclarations(node.members, <AccessorDeclaration>member);
if (member === accessors.firstAccessor) {
writeLine();
if (accessors.getAccessor) {
writeLine();
emitLeadingComments(accessors.getAccessor);
emitStart(accessors.getAccessor);
if (member.flags & NodeFlags.Static) {
write("static ");
}
write("get ");
emit((<MethodDeclaration>member).name);
emitSignatureAndBody(accessors.getAccessor);
emitEnd(accessors.getAccessor);
emitTrailingComments(accessors.getAccessor);
}
if (accessors.setAccessor) {
// We will only write new line if we just emit getAccessor
writeLine();
emitLeadingComments(accessors.setAccessor);
emitStart(accessors.setAccessor);
if (member.flags & NodeFlags.Static) {
write("static ");
}
write("set ");
emit((<MethodDeclaration>member).name);
emitSignatureAndBody(accessors.setAccessor);
emitEnd(accessors.setAccessor);
emitTrailingComments(accessors.setAccessor);;
}
}
}
});
}