microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-05-20 13:45:34 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

use getBaseTypeOfLiteralType

Browse Source
This commit is contained in:
Arthur Ozga
2017-02-15 14:24:25 -08:00
parent 18cba86e74
commit 9110461294
4 changed files with 21 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/services/codefixes/fixAddMissingMember.ts
View File

@@ -30,6 +30,22 @@ namespace ts.codefix {
// if function call, synthesize function declaration
if(token.parent.parent.kind == SyntaxKind.CallExpression) {
const callExpression = token.parent.parent as CallExpression;
if(callExpression.typeArguments) {
/**
* We can't in general know which arguments should use the type of the expression
* or the type of the type argument in the declaration. Consider
* ```
* class A {
* constructor(a: number){
* this.foo<number>(a,1,true);
* }
* }
* ```
*/
return undefined;
}
}
@@ -41,8 +57,8 @@ namespace ts.codefix {
binaryExpression.operatorToken;
const checker = context.program.getTypeChecker();
const type = checker.getWidenedType(checker.getTypeAtLocation(binaryExpression.right));
typeString = checker.typeToString(type);
const widenedType = checker.getBaseTypeOfLiteralType(checker.getTypeAtLocation(binaryExpression.right));
typeString = checker.typeToString(widenedType);
}
return [{

1
src/services/tsconfig.json
View File

@@ -78,6 +78,7 @@
"formatting/smartIndenter.ts",
"formatting/tokenRange.ts",
"codeFixProvider.ts",
"codefixes/fixAddMissingMember.ts",
"codefixes/fixExtendsInterfaceBecomesImplements.ts",
"codefixes/fixClassIncorrectlyImplementsInterface.ts",
"codefixes/fixClassDoesntImplementInheritedAbstractMember.ts",