microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-06-10 18:04:18 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

Do not create a temp for RHS if it's an identifier

Browse Source
This commit is contained in:
Jason Freeman
2015-03-04 16:06:37 -08:00
parent 4bb0587dd4
commit 905f35091f
22 changed files with 85 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
src/compiler/emitter.ts
View File

@@ -3523,17 +3523,26 @@ module ts {
// Do not call create recordTempDeclaration because we are declaring the temps
// right here. Recording means they will be declared later.
// In the case where the user wrote an identifier as the RHS, like this:
//
// for (var v of arr) { }
//
// we don't want to emit a temporary variable for the RHS, just use it directly.
var rhsIsIdentifier = node.expression.kind === SyntaxKind.Identifier;
var counter = createTempVariable(node, /*forLoopVariable*/ true);
var rhsReference = createTempVariable(node, /*forLoopVariable*/ false);
var rhsReference = rhsIsIdentifier ? <Identifier>node.expression : createTempVariable(node, /*forLoopVariable*/ false);
// _i = 0,
// _i = 0
emit(counter);
write(" = 0, ");
write(" = 0");
// _a = expr;
emit(rhsReference);
write(" = ");
emit(node.expression);
if (!rhsIsIdentifier) {
// , _a = expr
write(", ");
emit(rhsReference);
write(" = ");
emit(node.expression);
}
write("; ");
// _i < _a.length;