microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-02-05 08:11:30 -06:00
Code Issues Packages Projects Releases 212 Wiki Activity

fix(47062): support generic arrow function with default type parameter in tsx (#47112)

Browse Source 
* fix(47062): support generic arrow function with default type parameter in tsx

* test: update test "completionListIsGlobalCompletion"
This commit is contained in:
Hiroshi Ogawa 2021-12-15 02:02:36 +09:00 committed by GitHub
parent 67872a50d0
commit 8974fead2d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
7 changed files with 29 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/compiler/parser.ts
View File

@ -4433,7 +4433,7 @@ namespace ts {
return true;
}
}
else if (third === SyntaxKind.CommaToken) {
else if (third === SyntaxKind.CommaToken || third === SyntaxKind.EqualsToken) {
return true;
}
return false;

3
tests/baselines/reference/tsxGenericArrowFunctionParsing.errors.txt
View File

@ -36,4 +36,7 @@ tests/cases/conformance/jsx/file.tsx(24,25): error TS1382: Unexpected token. Did
!!! error TS1382: Unexpected token. Did you mean `{'>'}` or `>`?
x5.isElement;
// This is a generic function
var x6 = <T = string,>() => {};
x6();

6
tests/baselines/reference/tsxGenericArrowFunctionParsing.js
View File

@ -25,6 +25,9 @@ x4.isElement;
var x5 = <T extends>() => {}</T>;
x5.isElement;
// This is a generic function
var x6 = <T = string,>() => {};
x6();
//// [file.jsx]
@ -44,3 +47,6 @@ x4.isElement;
// This is an element
var x5 = <T extends>() => </T>;
x5.isElement;
// This is a generic function
var x6 = function () { };
x6();

7
tests/baselines/reference/tsxGenericArrowFunctionParsing.symbols
View File

@ -64,4 +64,11 @@ x5.isElement;
>x5 : Symbol(x5, Decl(file.tsx, 23, 3))
>isElement : Symbol(JSX.Element.isElement, Decl(file.tsx, 1, 20))
// This is a generic function
var x6 = <T = string,>() => {};
>x6 : Symbol(x6, Decl(file.tsx, 27, 3))
>T : Symbol(T, Decl(file.tsx, 27, 10))
x6();
>x6 : Symbol(x6, Decl(file.tsx, 27, 3))

8
tests/baselines/reference/tsxGenericArrowFunctionParsing.types
View File

@ -66,4 +66,12 @@ x5.isElement;
>x5 : JSX.Element
>isElement : any
// This is a generic function
var x6 = <T = string,>() => {};
>x6 : <T = string>() => void
><T = string,>() => {} : <T = string>() => void
x6();
>x6() : void
>x6 : <T = string>() => void

3
tests/cases/conformance/jsx/tsxGenericArrowFunctionParsing.tsx
View File

@ -26,3 +26,6 @@ x4.isElement;
var x5 = <T extends>() => {}</T>;
x5.isElement;
// This is a generic function
var x6 = <T = string,>() => {};
x6();

2
tests/cases/fourslash/completionListIsGlobalCompletion.ts
View File

@ -47,7 +47,7 @@ verify.completions(
{ marker: "7", exact: completion.globalsInsideFunction(x), isGlobalCompletion: true },
{ marker: "9", exact: ["x", "y"], isGlobalCompletion: false },
{ marker: "10", exact: completion.classElementKeywords, isGlobalCompletion: false, isNewIdentifierLocation: true },
{ marker: "13", exact: globals.filter(name => name !== 'z'), isGlobalCompletion: false },
{ marker: "13", exact: globals, isGlobalCompletion: false },
{ marker: "15", exact: globals.filter(name => name !== 'x'), isGlobalCompletion: true, isNewIdentifierLocation: true },
{ marker: "16", unsorted: [...x, completion.globalThisEntry, ...completion.globalsVars, completion.undefinedVarEntry].filter(name => name !== 'user'), isGlobalCompletion: false },
{ marker: "17", exact: completion.globalKeywords, isGlobalCompletion: false },