From 884f5ac258a2cb731dda9cf6ffaec12d3ce4cd68 Mon Sep 17 00:00:00 2001 From: Jake Bailey <5341706+jakebailey@users.noreply.github.com> Date: Tue, 14 Jun 2022 16:28:42 -0700 Subject: [PATCH] Ensure scripts compile, are checked in strict mode (#49524) --- package-lock.json | 9 +++++++++ package.json | 1 + scripts/buildProtocol.ts | 2 +- scripts/tsconfig.json | 2 +- 4 files changed, 12 insertions(+), 2 deletions(-) diff --git a/package-lock.json b/package-lock.json index 5cf6786778d..f85ac16f684 100644 --- a/package-lock.json +++ b/package-lock.json @@ -409,6 +409,15 @@ "integrity": "sha512-Q5Vn3yjTDyCMV50TB6VRIbQNxSE4OmZR86VSbGaNpfUolm0iePBB4KdEEHmxoY5sT2+2DIvXW0rvMDP2nHZ4Mg==", "dev": true }, + "@types/fs-extra": { + "version": "9.0.13", + "resolved": "https://registry.npmjs.org/@types/fs-extra/-/fs-extra-9.0.13.tgz", + "integrity": "sha512-nEnwB++1u5lVDM2UI4c1+5R+FYaKfaAzS4OococimjVm3nQw3TuzH5UNsocrcTBbhnerblyHj4A49qXbIiZdpA==", + "dev": true, + "requires": { + "@types/node": "*" + } + }, "@types/glob": { "version": "7.2.0", "resolved": "https://registry.npmjs.org/@types/glob/-/glob-7.2.0.tgz", diff --git a/package.json b/package.json index 56a00f94f7d..3dd9be115df 100644 --- a/package.json +++ b/package.json @@ -33,6 +33,7 @@ "@octokit/rest": "latest", "@types/chai": "latest", "@types/convert-source-map": "latest", + "@types/fs-extra": "^9.0.13", "@types/glob": "latest", "@types/gulp": "^4.0.9", "@types/gulp-concat": "latest", diff --git a/scripts/buildProtocol.ts b/scripts/buildProtocol.ts index 23026ca50f3..2cc843d4578 100644 --- a/scripts/buildProtocol.ts +++ b/scripts/buildProtocol.ts @@ -159,7 +159,7 @@ function writeProtocolFile(outputFile: string, protocolTs: string, typeScriptSer if (fileName === protocolFileName) { return ts.createSourceFile(fileName, protocolDts, options.target); } - return originalGetSourceFile.apply(host, [fileName]); + return originalGetSourceFile.apply(host, [fileName, ts.ScriptTarget.Latest]); }; const rootFiles = includeTypeScriptServices ? [protocolFileName, typeScriptServicesDts] : [protocolFileName]; return ts.createProgram(rootFiles, options, host); diff --git a/scripts/tsconfig.json b/scripts/tsconfig.json index 8383fbb0ff2..eeb14ab3781 100644 --- a/scripts/tsconfig.json +++ b/scripts/tsconfig.json @@ -1,6 +1,6 @@ { "compilerOptions": { - "strictNullChecks": true, + "strict": true, "removeComments": false, "declaration": false, "sourceMap": true,