microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-02-04 12:32:08 -06:00
Code Issues Packages Projects Releases 212 Wiki Activity

fix(57445): No inlay hints for property declaration types inferred from constructor (#57494)

Browse Source 
Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
This commit is contained in:
Oleksandr T 2024-03-12 20:50:46 +02:00 committed by GitHub
parent 47a800f5a4
commit 884d649846
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 23 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/services/inlayHints.ts
View File

@ -118,6 +118,7 @@ import {
tokenToString,
TupleTypeReference,
Type,
TypeFlags,
unescapeLeadingUnderscores,
UserPreferences,
usingSingleLineStringWriter,
@ -260,7 +261,10 @@ export function provideInlayHints(context: InlayHintsContext): InlayHint[] {
}
function visitVariableLikeDeclaration(decl: VariableDeclaration | PropertyDeclaration) {
if (!decl.initializer || isBindingPattern(decl.name) || isVariableDeclaration(decl) && !isHintableDeclaration(decl)) {
if (
decl.initializer === undefined && !(isPropertyDeclaration(decl) && !(checker.getTypeAtLocation(decl).flags & TypeFlags.Any)) ||
isBindingPattern(decl.name) || (isVariableDeclaration(decl) && !isHintableDeclaration(decl))
) {
return;
}

9
tests/baselines/reference/inlayHintsPropertyDeclarations.baseline
View File

@ -6,4 +6,13 @@
"position": 15,
"kind": "Type",
"whitespaceBefore": true
}
d;
^
{
"text": ": number | null",
"position": 50,
"kind": "Type",
"whitespaceBefore": true
}

9
tests/cases/fourslash/inlayHintsPropertyDeclarations.ts
View File

@ -1,9 +1,18 @@
/// <reference path="fourslash.ts" />
// @strict: true
//// class C {
//// a = 1
//// b: number = 2
//// c;
//// d;
////
//// constructor(value: number) {
//// this.d = value;
//// if (value <= 0) {
//// this.d = null;
//// }
//// }
//// }
verify.baselineInlayHints(undefined, {