From 83af77128d2943197fbc5667bfb8c5452f02ef08 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 22 Jan 2026 18:03:55 +0000 Subject: [PATCH] Fix tests with new errors from types default change Added explicit types arrays to tests that now have new errors: - moduleResolution_automaticTypeDirectiveNames: types: ["a"] - referenceTypesPreferedToPathIfPossible: types: ["node"] - typeRootsFromMultipleNodeModulesDirectories: types: ["dopey", "grumpy", "sneezy"] - typeRootsFromNodeModulesInParentDirectory: types: ["foo"] - typingsLookup3: types: ["jquery"] These tests relied on automatic @types inclusion and now require explicit configuration. Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com> --- tests/baselines/reference/typingsLookup3.errors.txt | 7 ++----- tests/baselines/reference/typingsLookup3.symbols | 9 ++++++++- tests/baselines/reference/typingsLookup3.trace.json | 12 +++++++++++- tests/baselines/reference/typingsLookup3.types | 11 +++++++++-- .../moduleResolution_automaticTypeDirectiveNames.ts | 1 + .../referenceTypesPreferedToPathIfPossible.ts | 1 + .../typeRootsFromMultipleNodeModulesDirectories.ts | 2 +- .../typeRootsFromNodeModulesInParentDirectory.ts | 2 +- tests/cases/conformance/typings/typingsLookup3.ts | 2 +- 9 files changed, 35 insertions(+), 12 deletions(-) diff --git a/tests/baselines/reference/typingsLookup3.errors.txt b/tests/baselines/reference/typingsLookup3.errors.txt index 8fac53ff718..699d5375bc0 100644 --- a/tests/baselines/reference/typingsLookup3.errors.txt +++ b/tests/baselines/reference/typingsLookup3.errors.txt @@ -1,17 +1,14 @@ /a.ts(1,23): error TS2688: Cannot find type definition file for 'JqUeRy'. -/a.ts(2,1): error TS2581: Cannot find name '$'. Do you need to install type definitions for jQuery? Try `npm i --save-dev @types/jquery`. ==== /tsconfig.json (0 errors) ==== - { "files": "a.ts" } + { "files": "a.ts", "compilerOptions": { "types": ["jquery"] } } -==== /a.ts (2 errors) ==== +==== /a.ts (1 errors) ==== /// ~~~~~~ !!! error TS2688: Cannot find type definition file for 'JqUeRy'. $.x; - ~ -!!! error TS2581: Cannot find name '$'. Do you need to install type definitions for jQuery? Try `npm i --save-dev @types/jquery`. ==== /node_modules/@types/jquery/index.d.ts (0 errors) ==== declare var $: { x: any }; diff --git a/tests/baselines/reference/typingsLookup3.symbols b/tests/baselines/reference/typingsLookup3.symbols index e677900ded5..743c42a1b80 100644 --- a/tests/baselines/reference/typingsLookup3.symbols +++ b/tests/baselines/reference/typingsLookup3.symbols @@ -1,7 +1,14 @@ //// [tests/cases/conformance/typings/typingsLookup3.ts] //// === /a.ts === - /// $.x; +>$.x : Symbol(x, Decl(index.d.ts, 0, 16)) +>$ : Symbol($, Decl(index.d.ts, 0, 11)) +>x : Symbol(x, Decl(index.d.ts, 0, 16)) + +=== /node_modules/@types/jquery/index.d.ts === +declare var $: { x: any }; +>$ : Symbol($, Decl(index.d.ts, 0, 11)) +>x : Symbol(x, Decl(index.d.ts, 0, 16)) diff --git a/tests/baselines/reference/typingsLookup3.trace.json b/tests/baselines/reference/typingsLookup3.trace.json index e8b95c476ca..d86e96fc05b 100644 --- a/tests/baselines/reference/typingsLookup3.trace.json +++ b/tests/baselines/reference/typingsLookup3.trace.json @@ -5,5 +5,15 @@ "Searching all ancestor node_modules directories for preferred extensions: Declaration.", "File '/node_modules/JqUeRy.d.ts' does not exist.", "File '/node_modules/@types/JqUeRy.d.ts' does not exist.", - "======== Type reference directive 'JqUeRy' was not resolved. ========" + "======== Type reference directive 'JqUeRy' was not resolved. ========", + "======== Resolving type reference directive 'jquery', containing file '/__inferred type names__.ts', root directory '/node_modules/@types'. ========", + "Resolving with primary search path '/node_modules/@types'.", + "File '/node_modules/@types/jquery/package.json' does not exist.", + "File '/node_modules/@types/jquery/index.d.ts' exists - use it as a name resolution result.", + "Resolving real path for '/node_modules/@types/jquery/index.d.ts', result '/node_modules/@types/jquery/index.d.ts'.", + "======== Type reference directive 'jquery' was successfully resolved to '/node_modules/@types/jquery/index.d.ts', primary: true. ========", + "File '/node_modules/@types/jquery/package.json' does not exist according to earlier cached lookups.", + "File '/node_modules/@types/package.json' does not exist.", + "File '/node_modules/package.json' does not exist.", + "File '/package.json' does not exist." ] \ No newline at end of file diff --git a/tests/baselines/reference/typingsLookup3.types b/tests/baselines/reference/typingsLookup3.types index 9f43c3fb778..378cdda8fa6 100644 --- a/tests/baselines/reference/typingsLookup3.types +++ b/tests/baselines/reference/typingsLookup3.types @@ -5,8 +5,15 @@ $.x; >$.x : any > : ^^^ ->$ : any -> : ^^^ +>$ : { x: any; } +> : ^^^^^ ^^^ +>x : any +> : ^^^ + +=== /node_modules/@types/jquery/index.d.ts === +declare var $: { x: any }; +>$ : { x: any; } +> : ^^^^^ ^^^ >x : any > : ^^^ diff --git a/tests/cases/compiler/moduleResolution_automaticTypeDirectiveNames.ts b/tests/cases/compiler/moduleResolution_automaticTypeDirectiveNames.ts index b5baa1bbe16..b4343dbaf4d 100644 --- a/tests/cases/compiler/moduleResolution_automaticTypeDirectiveNames.ts +++ b/tests/cases/compiler/moduleResolution_automaticTypeDirectiveNames.ts @@ -1,4 +1,5 @@ // @noImplicitReferences: true +// @types: a // @Filename: /node_modules/@types/.a/index.d.ts declare const a: number; diff --git a/tests/cases/compiler/referenceTypesPreferedToPathIfPossible.ts b/tests/cases/compiler/referenceTypesPreferedToPathIfPossible.ts index deabc4d0ac4..47a1e5fbc4f 100644 --- a/tests/cases/compiler/referenceTypesPreferedToPathIfPossible.ts +++ b/tests/cases/compiler/referenceTypesPreferedToPathIfPossible.ts @@ -1,5 +1,6 @@ // @declaration: true // @noImplicitReferences: true +// @types: node // @filename: /.src/node_modules/@types/node/index.d.ts declare module "url" { export class Url {} diff --git a/tests/cases/compiler/typeRootsFromMultipleNodeModulesDirectories.ts b/tests/cases/compiler/typeRootsFromMultipleNodeModulesDirectories.ts index b7f194706a8..fbdfcbedd96 100644 --- a/tests/cases/compiler/typeRootsFromMultipleNodeModulesDirectories.ts +++ b/tests/cases/compiler/typeRootsFromMultipleNodeModulesDirectories.ts @@ -24,4 +24,4 @@ import { z } from "abc"; x + y + z; // @Filename: /foo/bar/tsconfig.json -{} +{ "compilerOptions": { "types": ["dopey", "grumpy", "sneezy"] } } diff --git a/tests/cases/compiler/typeRootsFromNodeModulesInParentDirectory.ts b/tests/cases/compiler/typeRootsFromNodeModulesInParentDirectory.ts index 59b7d6a3188..e05d2be1da7 100644 --- a/tests/cases/compiler/typeRootsFromNodeModulesInParentDirectory.ts +++ b/tests/cases/compiler/typeRootsFromNodeModulesInParentDirectory.ts @@ -12,4 +12,4 @@ import { x } from "xyz"; x; // @Filename: /src/tsconfig.json -{} +{ "compilerOptions": { "types": ["foo"] } } diff --git a/tests/cases/conformance/typings/typingsLookup3.ts b/tests/cases/conformance/typings/typingsLookup3.ts index 62ac683ba2a..52be6a82337 100644 --- a/tests/cases/conformance/typings/typingsLookup3.ts +++ b/tests/cases/conformance/typings/typingsLookup3.ts @@ -4,7 +4,7 @@ // This tests that `types` references are not lowercased. // @filename: /tsconfig.json -{ "files": "a.ts" } +{ "files": "a.ts", "compilerOptions": { "types": ["jquery"] } } // @filename: /node_modules/@types/jquery/index.d.ts declare var $: { x: any };