From 80b64de1e45bc37df699b48d2a7ca452f711545b Mon Sep 17 00:00:00 2001 From: Mine Starks Date: Tue, 11 Jul 2017 14:50:55 -0700 Subject: [PATCH] Fix comment behavior in remove unused named bindings --- src/services/codefixes/fixUnusedIdentifier.ts | 3 +-- tests/cases/fourslash/unusedImports14FS.ts | 12 ++++++++++++ 2 files changed, 13 insertions(+), 2 deletions(-) create mode 100644 tests/cases/fourslash/unusedImports14FS.ts diff --git a/src/services/codefixes/fixUnusedIdentifier.ts b/src/services/codefixes/fixUnusedIdentifier.ts index 6335ebb226b..dd4c030b69d 100644 --- a/src/services/codefixes/fixUnusedIdentifier.ts +++ b/src/services/codefixes/fixUnusedIdentifier.ts @@ -128,8 +128,7 @@ namespace ts.codefix { // import d|, { a }| from './file' const previousToken = getTokenAtPosition(sourceFile, namedBindings.pos - 1, /*includeJsDocComment*/ false); if (previousToken && previousToken.kind === SyntaxKind.CommaToken) { - const startPosition = textChanges.getAdjustedStartPosition(sourceFile, previousToken, {}, textChanges.Position.FullStart); - return [deleteRange({ pos: startPosition, end: namedBindings.end })]; + return [deleteRange({ pos: previousToken.getStart(), end: namedBindings.end })]; } return undefined; } diff --git a/tests/cases/fourslash/unusedImports14FS.ts b/tests/cases/fourslash/unusedImports14FS.ts new file mode 100644 index 00000000000..90bd2c50587 --- /dev/null +++ b/tests/cases/fourslash/unusedImports14FS.ts @@ -0,0 +1,12 @@ +/// + +// @noUnusedLocals: true +// @Filename: file2.ts +//// [| import /* 1 */ A /* 2 */, /* 3 */ { x } from './a'; |] +//// console.log(A); + +// @Filename: file1.ts +//// export default 10; +//// export var x = 10; + +verify.rangeAfterCodeFix("import /* 1 */ A /* 2 */ from './a';"); \ No newline at end of file