microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-02-06 02:33:53 -06:00
Code Issues Packages Projects Releases 212 Wiki Activity

Revert "Disallow incremental with noEmit"

Browse Source
This commit is contained in:
Sheetal Nandi 2019-10-08 13:41:40 -07:00 committed by GitHub
parent f1c0300c02
commit 8032984de2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
9 changed files with 0 additions and 82 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/compiler/program.ts
View File

@ -2929,10 +2929,6 @@ namespace ts {
programDiagnostics.add(createCompilerDiagnostic(Diagnostics.Option_incremental_can_only_be_specified_using_tsconfig_emitting_to_single_file_or_when_option_tsBuildInfoFile_is_specified));
}
if (options.noEmit && isIncrementalCompilation(options)) {
createDiagnosticForOptionName(Diagnostics.Option_0_cannot_be_specified_with_option_1, "noEmit", options.incremental ? "incremental" : "composite");
}
verifyProjectReferences();
// List of collected files is complete; validate exhautiveness if this is a project with a file list

19
tests/baselines/reference/noEmitAndComposite.errors.txt
View File

@ -1,19 +0,0 @@
/tsconfig.json(3,9): error TS5053: Option 'noEmit' cannot be specified with option 'composite'.
/tsconfig.json(4,9): error TS5053: Option 'noEmit' cannot be specified with option 'composite'.
==== /tsconfig.json (2 errors) ====
{
"compilerOptions": {
"noEmit": true,
~~~~~~~~
!!! error TS5053: Option 'noEmit' cannot be specified with option 'composite'.
"composite": true
~~~~~~~~~~~
!!! error TS5053: Option 'noEmit' cannot be specified with option 'composite'.
}
}
==== /a.ts (0 errors) ====
const x = 10;

4
tests/baselines/reference/noEmitAndComposite.symbols
View File

@ -1,4 +0,0 @@
=== /a.ts ===
const x = 10;
>x : Symbol(x, Decl(a.ts, 0, 5))

5
tests/baselines/reference/noEmitAndComposite.types
View File

@ -1,5 +0,0 @@
=== /a.ts ===
const x = 10;
>x : 10
>10 : 10

20
tests/baselines/reference/noEmitAndIncremental.errors.txt
View File

@ -1,20 +0,0 @@
/tsconfig.json(3,9): error TS5053: Option 'noEmit' cannot be specified with option 'incremental'.
/tsconfig.json(4,9): error TS5053: Option 'noEmit' cannot be specified with option 'incremental'.
==== /tsconfig.json (2 errors) ====
{
"compilerOptions": {
"noEmit": true,
~~~~~~~~
!!! error TS5053: Option 'noEmit' cannot be specified with option 'incremental'.
"incremental": true
~~~~~~~~~~~~~
!!! error TS5053: Option 'noEmit' cannot be specified with option 'incremental'.
}
}
==== /a.ts (0 errors) ====
const x = 10;

4
tests/baselines/reference/noEmitAndIncremental.symbols
View File

@ -1,4 +0,0 @@
=== /a.ts ===
const x = 10;
>x : Symbol(x, Decl(a.ts, 0, 5))

5
tests/baselines/reference/noEmitAndIncremental.types
View File

@ -1,5 +0,0 @@
=== /a.ts ===
const x = 10;
>x : 10
>10 : 10

10
tests/cases/compiler/noEmitAndComposite.ts
View File

@ -1,10 +0,0 @@
// @Filename: /a.ts
const x = 10;
// @Filename: /tsconfig.json
{
"compilerOptions": {
"noEmit": true,
"composite": true
}
}

11
tests/cases/compiler/noEmitAndIncremental.ts
View File

@ -1,11 +0,0 @@
// @Filename: /a.ts
const x = 10;
// @Filename: /tsconfig.json
{
"compilerOptions": {
"noEmit": true,
"incremental": true
}
}