From 7fb6c99c1940f7f7828fdc836834224ff066b7cf Mon Sep 17 00:00:00 2001 From: Daniel Rosenwasser Date: Thu, 9 Feb 2023 15:37:22 -0800 Subject: [PATCH] Don't create an unnecessary text span in `isInStringOrRegularExpressionOrTemplateLiteral` (#52697) --- src/services/completions.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/services/completions.ts b/src/services/completions.ts index c55783b060a..08e7fdc96a3 100644 --- a/src/services/completions.ts +++ b/src/services/completions.ts @@ -36,7 +36,6 @@ import { createPackageJsonImportFilter, createPrinter, createSortedArray, - createTextRangeFromSpan, createTextSpanFromBounds, createTextSpanFromNode, createTextSpanFromRange, @@ -3697,7 +3696,7 @@ function getCompletionData( // 2. at the end position of an unterminated token. // 3. at the end of a regular expression (due to trailing flags like '/foo/g'). return (isRegularExpressionLiteral(contextToken) || isStringTextContainingNode(contextToken)) && ( - rangeContainsPositionExclusive(createTextRangeFromSpan(createTextSpanFromNode(contextToken)), position) || + rangeContainsPositionExclusive(contextToken, position) || position === contextToken.end && (!!contextToken.isUnterminated || isRegularExpressionLiteral(contextToken))); }