microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-02-04 21:53:42 -06:00
Code Issues Packages Projects Releases 212 Wiki Activity

Reuse operandType in checkPrefixUnaryExpression (#53682)

Browse Source
This commit is contained in:
Jake Bailey 2023-04-06 13:37:12 -07:00 committed by GitHub
parent 287ee41cf2
commit 7f6376794e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 58 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/compiler/checker.ts
View File

@ -36120,7 +36120,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
}
return getUnaryResultType(operandType);
case SyntaxKind.ExclamationToken:
checkTruthinessExpression(node.operand);
checkTruthinessOfType(operandType, node.operand);
const facts = getTypeFacts(operandType) & (TypeFacts.Truthy | TypeFacts.Falsy);
return facts === TypeFacts.Truthy ? falseType :
facts === TypeFacts.Falsy ? trueType :

11
tests/baselines/reference/nestedUnaryExpressionHang.errors.txt Normal file
View File

@ -0,0 +1,11 @@
tests/cases/compiler/nestedUnaryExpressionHang.ts(1,6): error TS2363: The right-hand side of an arithmetic operation must be of type 'any', 'number', 'bigint' or an enum type.
tests/cases/compiler/nestedUnaryExpressionHang.ts(1,34): error TS1109: Expression expected.
==== tests/cases/compiler/nestedUnaryExpressionHang.ts (2 errors) ====
3333%!!!!!!!!!!!!!!!!!!!!!!!!!!!!
~~~~~~~~~~~~~~~~~~~~~~~~~~~~
!!! error TS2363: The right-hand side of an arithmetic operation must be of type 'any', 'number', 'bigint' or an enum type.
!!! error TS1109: Expression expected.

6
tests/baselines/reference/nestedUnaryExpressionHang.js Normal file
View File

@ -0,0 +1,6 @@
//// [nestedUnaryExpressionHang.ts]
3333%!!!!!!!!!!!!!!!!!!!!!!!!!!!!
//// [nestedUnaryExpressionHang.js]
3333 % !!!!!!!!!!!!!!!!!!!!!!!!!!!!;

4
tests/baselines/reference/nestedUnaryExpressionHang.symbols Normal file
View File

@ -0,0 +1,4 @@
=== tests/cases/compiler/nestedUnaryExpressionHang.ts ===
3333%!!!!!!!!!!!!!!!!!!!!!!!!!!!!

35
tests/baselines/reference/nestedUnaryExpressionHang.types Normal file
View File

@ -0,0 +1,35 @@
=== tests/cases/compiler/nestedUnaryExpressionHang.ts ===
3333%!!!!!!!!!!!!!!!!!!!!!!!!!!!!
>3333%!!!!!!!!!!!!!!!!!!!!!!!!!!!! : number
>3333 : 3333
>!!!!!!!!!!!!!!!!!!!!!!!!!!!! : boolean
>!!!!!!!!!!!!!!!!!!!!!!!!!!! : boolean
>!!!!!!!!!!!!!!!!!!!!!!!!!! : boolean
>!!!!!!!!!!!!!!!!!!!!!!!!! : boolean
>!!!!!!!!!!!!!!!!!!!!!!!! : boolean
>!!!!!!!!!!!!!!!!!!!!!!! : boolean
>!!!!!!!!!!!!!!!!!!!!!! : boolean
>!!!!!!!!!!!!!!!!!!!!! : boolean
>!!!!!!!!!!!!!!!!!!!! : boolean
>!!!!!!!!!!!!!!!!!!! : boolean
>!!!!!!!!!!!!!!!!!! : boolean
>!!!!!!!!!!!!!!!!! : boolean
>!!!!!!!!!!!!!!!! : boolean
>!!!!!!!!!!!!!!! : boolean
>!!!!!!!!!!!!!! : boolean
>!!!!!!!!!!!!! : boolean
>!!!!!!!!!!!! : boolean
>!!!!!!!!!!! : boolean
>!!!!!!!!!! : boolean
>!!!!!!!!! : boolean
>!!!!!!!! : boolean
>!!!!!!! : boolean
>!!!!!! : boolean
>!!!!! : boolean
>!!!! : boolean
>!!! : boolean
>!! : boolean
>! : boolean
> : any

1
tests/cases/compiler/nestedUnaryExpressionHang.ts Normal file
View File

@ -0,0 +1 @@
3333%!!!!!!!!!!!!!!!!!!!!!!!!!!!!