microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-05-28 09:22:42 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

fix: CompilerHost.getSourceFile is being called for odd filenames besides the one being compiled

Browse Source 
Ignore falsy file names from `getDefaultLibraryFileName`

Closes: #13629
This commit is contained in:
Alan Agius
2018-04-02 20:58:37 +02:00
parent 7714a2bb5b
commit 7e482b27fb
4 changed files with 43 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/compiler/program.ts
View File

@@ -611,8 +611,9 @@ namespace ts {
if (!skipDefaultLib) {
// If '--lib' is not specified, include default library file according to '--target'
// otherwise, using options specified in '--lib' instead of '--target' default library file
if (!options.lib) {
processRootFile(getDefaultLibraryFileName(), /*isDefaultLib*/ true);
const defaultLibraryFileName = getDefaultLibraryFileName();
if (!options.lib && defaultLibraryFileName) {
processRootFile(defaultLibraryFileName, /*isDefaultLib*/ true);
}
else {
forEach(options.lib, libFileName => {
@@ -1117,7 +1118,7 @@ namespace ts {
// otherwise, using options specified in '--lib' instead of '--target' default library file
const equalityComparer = host.useCaseSensitiveFileNames() ? equateStringsCaseSensitive : equateStringsCaseInsensitive;
if (!options.lib) {
return equalityComparer(file.fileName, getDefaultLibraryFileName());
return equalityComparer(file.fileName, getDefaultLibraryFileName());
}
else {
return forEach(options.lib, libFileName => equalityComparer(file.fileName, combinePaths(defaultLibraryPath, libFileName)));