From 7cc0f755ce66509b9780dc6f9200e1fe7f98a481 Mon Sep 17 00:00:00 2001 From: Andrew Casey Date: Tue, 1 Feb 2022 15:59:59 -0800 Subject: [PATCH] Use node moduleResolution everywhere (#47687) TestRunner was already using it, but upstream projects (e.g. Compiler) were not, causing TestRunner to re-parse and re-bind all upstream files in (at least) editor scenarios), slowing down initial project load. In local testing, this cut a find-all-refs call in checker.ts from 5s to 2.5s. --- src/testRunner/tsconfig.json | 1 - src/tsconfig-base.json | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/src/testRunner/tsconfig.json b/src/testRunner/tsconfig.json index e85df70861e..2caa9873f29 100644 --- a/src/testRunner/tsconfig.json +++ b/src/testRunner/tsconfig.json @@ -2,7 +2,6 @@ "extends": "../tsconfig-noncomposite-base", "compilerOptions": { "outFile": "../../built/local/run.js", - "moduleResolution": "node", "composite": false, "declaration": false, "declarationMap": false, diff --git a/src/tsconfig-base.json b/src/tsconfig-base.json index b0515e0a023..51cf414728d 100644 --- a/src/tsconfig-base.json +++ b/src/tsconfig-base.json @@ -3,7 +3,7 @@ "pretty": true, "lib": ["es2015.iterable", "es2015.generator", "es5"], "target": "es5", - "moduleResolution": "classic", + "moduleResolution": "node", "rootDir": ".", "declaration": true,