microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-05-21 18:22:58 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

When removing the errors for the exports from the file, apart from removing transitive exports, remove the diagnostics of file that import these exports

Browse Source 
Fixes #28983
This commit is contained in:
Sheetal Nandi
2018-12-12 13:00:30 -08:00
parent fecbdb68bd
commit 7c92d09e23
2 changed files with 159 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/compiler/builder.ts
View File

@@ -281,10 +281,19 @@ namespace ts {
}
// If exported from path is not from cache and exported modules has path, all files referencing file exported from are affected
return !!forEachEntry(state.exportedModulesMap!, (exportedModules, exportedFromPath) =>
if (forEachEntry(state.exportedModulesMap!, (exportedModules, exportedFromPath) =>
!state.currentAffectedFilesExportedModulesMap!.has(exportedFromPath) && // If we already iterated this through cache, ignore it
exportedModules.has(filePath) &&
removeSemanticDiagnosticsOfFileAndExportsOfFile(state, exportedFromPath as Path, seenFileAndExportsOfFile)
)) {
return true;
}
// Remove diagnostics of files that import this file (without going to exports of referencing files)
return !!forEachEntry(state.referencedMap!, (referencesInFile, referencingFilePath) =>
referencesInFile.has(filePath) &&
!seenFileAndExportsOfFile.has(referencingFilePath) && // Not already removed diagnostic file
removeSemanticDiagnosticsOf(state, referencingFilePath as Path) // Dont add to seen since this is not yet done with the export removal
);
}