microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-05-18 07:29:16 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

Don't crash when renaming a JS property declared via module.exports (#40297)

Browse Source 
Fixes #38070

When the originating definition was of the form
```js
module.exports.foo = expr
```
we were incorrectly trying to call `resolveName` on just the `foo` portion to get the "local" symbol, which simply failed to resolve (or would have resolved to the wrong thing), but for this form, the local symbol is just the containing property access expression
This commit is contained in:
Ryan Cavanaugh
2021-03-11 07:23:19 -08:00
committed by GitHub
parent 3c576f108c
commit 79d3058b83
4 changed files with 185 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/services/importTracker.ts
View File

@@ -644,7 +644,8 @@ namespace ts.FindAllReferences {
return checker.getExportSpecifierLocalTargetSymbol(declaration)!;
}
else if (isPropertyAccessExpression(declaration) && isModuleExportsAccessExpression(declaration.expression) && !isPrivateIdentifier(declaration.name)) {
return checker.getExportSpecifierLocalTargetSymbol(declaration.name)!;
// Export of form 'module.exports.propName = expr';
return checker.getSymbolAtLocation(declaration)!;
}
else if (isShorthandPropertyAssignment(declaration)
&& isBinaryExpression(declaration.parent.parent)