microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-05-16 06:35:35 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

Apply 'no-unnecessary-initializer' lint rule (#22014)

Browse Source 
* Apply 'no-unnecessary-initializer' lint rule

Forbids `let`/`const` statements to be initialized to `undefined`, since that's the initial value by default anyway.
The auto-fixer also happened to remove two unnecessary `as number` casts in `src/harness/parallel/worker.ts`.

For historical data: to run with `--fix`, I modified the line in `Jakefile.js` that declared the `cmd` for running TSLint.

* Moved worker.ts type assertions to parameters
This commit is contained in:
Josh Goldberg
2018-03-06 07:30:40 -08:00
committed by Andy
parent 5e593acad9
commit 7826b38426
18 changed files with 50 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/server/client.ts
View File

@@ -607,7 +607,7 @@ namespace ts.server {
const edits: FileTextChanges[] = this.convertCodeEditsToTextChanges(response.body.edits);
const renameFilename: string | undefined = response.body.renameFilename;
let renameLocation: number | undefined = undefined;
let renameLocation: number | undefined;
if (renameFilename !== undefined) {
renameLocation = this.lineOffsetToPosition(renameFilename, response.body.renameLocation);
}

4
src/server/session.ts
View File

@@ -1560,7 +1560,7 @@ namespace ts.server {
}
private extractPositionAndRange(args: protocol.FileLocationOrRangeRequestArgs, scriptInfo: ScriptInfo): { position: number, textRange: TextRange } {
let position: number = undefined;
let position: number;
let textRange: TextRange;
if (this.isLocation(args)) {
position = getPosition(args);
@@ -1676,7 +1676,7 @@ namespace ts.server {
}
private getStartAndEndPosition(args: protocol.FileRangeRequestArgs, scriptInfo: ScriptInfo) {
let startPosition: number = undefined, endPosition: number = undefined;
let startPosition: number, endPosition: number;
if (args.startPosition !== undefined) {
startPosition = args.startPosition;
}