microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-05-20 13:45:34 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

Expand anti-parent-barrel auto-import heuristic to all moduleResolution modes (#57342)

Browse Source
This commit is contained in:
Andrew Branch
2024-02-08 11:12:35 -08:00
committed by GitHub
parent 10a3872de4
commit 76cf0928f2
3 changed files with 62 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/services/codefixes/importFixes.ts
View File

@@ -97,7 +97,6 @@ import {
mapDefined,
memoizeOne,
ModuleKind,
ModuleResolutionKind,
moduleResolutionUsesNodeModules,
moduleSpecifiers,
MultiMap,
@@ -1054,13 +1053,11 @@ function compareModuleSpecifiers(
// This is a simple heuristic to try to avoid creating an import cycle with a barrel re-export.
// E.g., do not `import { Foo } from ".."` when you could `import { Foo } from "../Foo"`.
// This can produce false positives or negatives if re-exports cross into sibling directories
// (e.g. `export * from "../whatever"`) or are not named "index" (we don't even try to consider
// this if we're in a resolution mode where you can't drop trailing "/index" from paths).
// (e.g. `export * from "../whatever"`) or are not named "index".
function isFixPossiblyReExportingImportingFile(fix: ImportFixWithModuleSpecifier, importingFile: SourceFile, compilerOptions: CompilerOptions, toPath: (fileName: string) => Path): boolean {
if (
fix.isReExport &&
fix.exportInfo?.moduleFileName &&
getEmitModuleResolutionKind(compilerOptions) === ModuleResolutionKind.Node10 &&
isIndexFileName(fix.exportInfo.moduleFileName)
) {
const reExportDir = toPath(getDirectoryPath(fix.exportInfo.moduleFileName));