microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-02-04 21:53:42 -06:00
Code Issues Packages Projects Releases 212 Wiki Activity

Fix crash in signatureHelp

Browse Source
This commit is contained in:
Ron Buckton 2019-01-22 15:02:30 -08:00
parent 3a2f6a3ed1
commit 76b78a4df5
3 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/services/signatureHelp.ts
View File

@ -452,7 +452,7 @@ namespace ts.SignatureHelp {
}
function getContainingArgumentInfo(node: Node, position: number, sourceFile: SourceFile, checker: TypeChecker, isManuallyInvoked: boolean): ArgumentListInfo | undefined {
for (let n = node; isManuallyInvoked || (!isBlock(n) && !isSourceFile(n)); n = n.parent) {
for (let n = node; !isSourceFile(n) && (isManuallyInvoked || !isBlock(n)); n = n.parent) {
// If the node is not a subspan of its parent, this is a big problem.
// There have been crashes that might be caused by this violation.
Debug.assert(rangeContainsRange(n.parent, n), "Not a subspan", () => `Child: ${Debug.showSyntaxKind(n)}, parent: ${Debug.showSyntaxKind(n.parent)}`);

4
src/tsserver/server.ts
View File

@ -967,4 +967,8 @@ namespace ts.server {
(process as any).noAsar = true;
// Start listening
ioSession.listen();
if (ts.sys.tryEnableSourceMapsForHost && /^development$/i.test(ts.sys.getEnvironmentVariable("NODE_ENV"))) {
ts.sys.tryEnableSourceMapsForHost();
}
}

6
tests/cases/fourslash/signatureHelpAtEOF2.ts Normal file
View File

@ -0,0 +1,6 @@
/// <reference path='fourslash.ts' />
////console.log()
/////**/
verify.noSignatureHelpForTriggerReason({ kind: "invoked" }, "");