From 76869eeda1dc5ab004e3d43cc7ce001034ae9c14 Mon Sep 17 00:00:00 2001 From: Andrew Branch Date: Fri, 30 Jun 2023 10:13:22 -0700 Subject: [PATCH] Fix relative path completions when self package.json has typesVersions (#54842) --- src/services/stringCompletions.ts | 2 +- .../pathCompletionsTypesVersionsLocal.ts | 22 +++++++++++++++++++ 2 files changed, 23 insertions(+), 1 deletion(-) create mode 100644 tests/cases/fourslash/pathCompletionsTypesVersionsLocal.ts diff --git a/src/services/stringCompletions.ts b/src/services/stringCompletions.ts index 47a68e9d2e3..a77cf7648e7 100644 --- a/src/services/stringCompletions.ts +++ b/src/services/stringCompletions.ts @@ -598,7 +598,7 @@ function getCompletionEntriesForRelativeModules(literalValue: string, scriptDire compilerOptions.rootDirs, literalValue, scriptDirectory, extensionOptions, compilerOptions, host, scriptPath); } else { - return arrayFrom(getCompletionEntriesForDirectoryFragment(literalValue, scriptDirectory, extensionOptions, host, /*moduleSpecifierIsRelative*/ false, scriptPath).values()); + return arrayFrom(getCompletionEntriesForDirectoryFragment(literalValue, scriptDirectory, extensionOptions, host, /*moduleSpecifierIsRelative*/ true, scriptPath).values()); } } diff --git a/tests/cases/fourslash/pathCompletionsTypesVersionsLocal.ts b/tests/cases/fourslash/pathCompletionsTypesVersionsLocal.ts new file mode 100644 index 00000000000..98c8902c020 --- /dev/null +++ b/tests/cases/fourslash/pathCompletionsTypesVersionsLocal.ts @@ -0,0 +1,22 @@ +/// + +// @Filename: /package.json +//// { +//// "typesVersions": { +//// "*": { +//// "*": ["./src/*"] +//// } +//// } +//// } + +// @Filename: /src/add.ts +//// export function add(a: number, b: number) { return a + b; } + +// @Filename: /src/index.ts +//// import { add } from ".//**/"; + +verify.completions({ + marker: "", + isNewIdentifierLocation: true, + exact: ["add"], +});