microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-02-05 16:38:05 -06:00
Code Issues Packages Projects Releases 212 Wiki Activity

Don't bother trying to get the name of a default export (#25773)

Browse Source 
* Don't bother trying to get the name of a default export

* Fix lint
This commit is contained in:
Andy 2018-07-18 11:43:13 -07:00 committed by GitHub
parent d92c26db69
commit 751f20e8bc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 45 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/compiler/binder.ts
View File

@ -306,7 +306,7 @@ namespace ts {
}
function getDisplayName(node: Declaration): string {
return isNamedDeclaration(node) ? declarationNameToString(node.name) : unescapeLeadingUnderscores(getDeclarationName(node)!); // TODO: GH#18217
return isNamedDeclaration(node) ? declarationNameToString(node.name) : unescapeLeadingUnderscores(Debug.assertDefined(getDeclarationName(node)));
}
/**
@ -383,9 +383,11 @@ namespace ts {
let message = symbol.flags & SymbolFlags.BlockScopedVariable
? Diagnostics.Cannot_redeclare_block_scoped_variable_0
: Diagnostics.Duplicate_identifier_0;
let messageNeedsName = true;
if (symbol.flags & SymbolFlags.Enum || includes & SymbolFlags.Enum) {
message = Diagnostics.Enum_declarations_can_only_merge_with_namespace_or_other_enum_declarations;
messageNeedsName = false;
}
if (symbol.declarations && symbol.declarations.length) {
@ -394,6 +396,7 @@ namespace ts {
// We'll know whether we have other default exports depending on if `symbol` already has a declaration list set.
if (isDefaultExport) {
message = Diagnostics.A_module_cannot_have_multiple_default_exports;
messageNeedsName = false;
}
else {
// This is to properly report an error in the case "export default { }" is after export default of class declaration or function declaration.
@ -403,14 +406,16 @@ namespace ts {
if (symbol.declarations && symbol.declarations.length &&
(node.kind === SyntaxKind.ExportAssignment && !(<ExportAssignment>node).isExportEquals)) {
message = Diagnostics.A_module_cannot_have_multiple_default_exports;
messageNeedsName = false;
}
}
}
forEach(symbol.declarations, declaration => {
file.bindDiagnostics.push(createDiagnosticForNode(getNameOfDeclaration(declaration) || declaration, message, getDisplayName(declaration)));
});
file.bindDiagnostics.push(createDiagnosticForNode(getNameOfDeclaration(node) || node, message, getDisplayName(node)));
const addError = (decl: Declaration): void => {
file.bindDiagnostics.push(createDiagnosticForNode(getNameOfDeclaration(decl) || decl, message, messageNeedsName ? getDisplayName(decl) : undefined));
};
forEach(symbol.declarations, addError);
addError(node);
symbol = createSymbol(SymbolFlags.None, name);
}

12
tests/baselines/reference/duplicateDefaultExport.errors.txt Normal file
View File

@ -0,0 +1,12 @@
tests/cases/compiler/duplicateDefaultExport.ts(1,1): error TS2528: A module cannot have multiple default exports.
tests/cases/compiler/duplicateDefaultExport.ts(2,1): error TS2528: A module cannot have multiple default exports.
==== tests/cases/compiler/duplicateDefaultExport.ts (2 errors) ====
export default 0;
~~~~~~~~~~~~~~~~~
!!! error TS2528: A module cannot have multiple default exports.
export default function() {}
~~~~~~
!!! error TS2528: A module cannot have multiple default exports.

11
tests/baselines/reference/duplicateDefaultExport.js Normal file
View File

@ -0,0 +1,11 @@
//// [duplicateDefaultExport.ts]
export default 0;
export default function() {}
//// [duplicateDefaultExport.js]
"use strict";
exports.__esModule = true;
exports["default"] = 0;
function default_1() { }
exports["default"] = default_1;

5
tests/baselines/reference/duplicateDefaultExport.symbols Normal file
View File

@ -0,0 +1,5 @@
=== tests/cases/compiler/duplicateDefaultExport.ts ===
export default 0;
No type information for this code.export default function() {}
No type information for this code.
No type information for this code.

5
tests/baselines/reference/duplicateDefaultExport.types Normal file
View File

@ -0,0 +1,5 @@
=== tests/cases/compiler/duplicateDefaultExport.ts ===
export default 0;
No type information for this code.export default function() {}
No type information for this code.
No type information for this code.

2
tests/cases/compiler/duplicateDefaultExport.ts Normal file
View File

@ -0,0 +1,2 @@
export default 0;
export default function() {}