From 7499c7c279933ac2fd35aa5ce11e82d319ec1a59 Mon Sep 17 00:00:00 2001 From: Yui T Date: Thu, 17 Dec 2015 18:34:21 -0800 Subject: [PATCH] Address feedback --- src/harness/fourslash.ts | 2 +- .../cases/fourslash/findAllRefsParameterPropertyDeclaration1.ts | 2 +- .../cases/fourslash/findAllRefsParameterPropertyDeclaration2.ts | 2 +- .../cases/fourslash/findAllRefsParameterPropertyDeclaration3.ts | 2 +- tests/cases/fourslash/fourslash.ts | 2 +- tests/cases/fourslash/renameParameterPropertyDeclaration1.ts | 2 +- tests/cases/fourslash/renameParameterPropertyDeclaration2.ts | 2 +- tests/cases/fourslash/renameParameterPropertyDeclaration3.ts | 2 +- tests/cases/fourslash/renameParameterPropertyDeclaration4.ts | 2 +- tests/cases/fourslash/renameParameterPropertyDeclaration5.ts | 2 +- 10 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/harness/fourslash.ts b/src/harness/fourslash.ts index 796dc1134a1..d5e1687b305 100644 --- a/src/harness/fourslash.ts +++ b/src/harness/fourslash.ts @@ -2768,7 +2768,7 @@ namespace FourSlashInterface { this.state.verifyCompletionListItemsCountIsGreaterThan(count, this.negative); } - public assertRangesEmpty(ranges: FourSlash.Range[]) { + public assertHasRanges(ranges: FourSlash.Range[]) { assert(ranges.length !== 0, "Array of ranges is expected to be non-empty"); } diff --git a/tests/cases/fourslash/findAllRefsParameterPropertyDeclaration1.ts b/tests/cases/fourslash/findAllRefsParameterPropertyDeclaration1.ts index 828b143a4ce..4018698f4ef 100644 --- a/tests/cases/fourslash/findAllRefsParameterPropertyDeclaration1.ts +++ b/tests/cases/fourslash/findAllRefsParameterPropertyDeclaration1.ts @@ -8,7 +8,7 @@ //// } const ranges = test.ranges(); -verify.assertRangesEmpty(ranges); +verify.assertHasRanges(ranges); for (const range of ranges) { goTo.position(range.start); diff --git a/tests/cases/fourslash/findAllRefsParameterPropertyDeclaration2.ts b/tests/cases/fourslash/findAllRefsParameterPropertyDeclaration2.ts index 6b15b334c28..a450a77e2dc 100644 --- a/tests/cases/fourslash/findAllRefsParameterPropertyDeclaration2.ts +++ b/tests/cases/fourslash/findAllRefsParameterPropertyDeclaration2.ts @@ -8,7 +8,7 @@ //// } let ranges = test.ranges(); -verify.assertRangesEmpty(ranges); +verify.assertHasRanges(ranges); for (let range of ranges) { goTo.position(range.start); diff --git a/tests/cases/fourslash/findAllRefsParameterPropertyDeclaration3.ts b/tests/cases/fourslash/findAllRefsParameterPropertyDeclaration3.ts index 1310841eed4..82fd67dfc9b 100644 --- a/tests/cases/fourslash/findAllRefsParameterPropertyDeclaration3.ts +++ b/tests/cases/fourslash/findAllRefsParameterPropertyDeclaration3.ts @@ -8,7 +8,7 @@ //// } const ranges = test.ranges(); -verify.assertRangesEmpty(ranges); +verify.assertHasRanges(ranges); for (const range of ranges) { goTo.position(range.start); diff --git a/tests/cases/fourslash/fourslash.ts b/tests/cases/fourslash/fourslash.ts index fcb221e8233..dd443e942cf 100644 --- a/tests/cases/fourslash/fourslash.ts +++ b/tests/cases/fourslash/fourslash.ts @@ -137,7 +137,7 @@ declare namespace FourSlashInterface { verifyDefinitionsName(name: string, containerName: string): void; } class verify extends verifyNegatable { - assertRangesEmpty(ranges: FourSlash.Range[]): void; + assertHasRanges(ranges: FourSlash.Range[]): void; caretAtMarker(markerName?: string): void; indentationIs(numberOfSpaces: number): void; indentationAtPositionIs(fileName: string, position: number, numberOfSpaces: number, indentStyle?: ts.IndentStyle): void; diff --git a/tests/cases/fourslash/renameParameterPropertyDeclaration1.ts b/tests/cases/fourslash/renameParameterPropertyDeclaration1.ts index 37db51447ca..42bfbf63a47 100644 --- a/tests/cases/fourslash/renameParameterPropertyDeclaration1.ts +++ b/tests/cases/fourslash/renameParameterPropertyDeclaration1.ts @@ -8,7 +8,7 @@ //// } let ranges = test.ranges(); -verify.assertRangesEmpty(ranges); +verify.assertHasRanges(ranges); for (let range of ranges) { goTo.position(range.start); verify.renameLocations(/*findInStrings*/ false, /*findInComments*/ false); diff --git a/tests/cases/fourslash/renameParameterPropertyDeclaration2.ts b/tests/cases/fourslash/renameParameterPropertyDeclaration2.ts index c5e44438ee3..e7ef9d1c1a2 100644 --- a/tests/cases/fourslash/renameParameterPropertyDeclaration2.ts +++ b/tests/cases/fourslash/renameParameterPropertyDeclaration2.ts @@ -8,7 +8,7 @@ //// } let ranges = test.ranges(); -verify.assertRangesEmpty(ranges); +verify.assertHasRanges(ranges); for (let range of ranges) { goTo.position(range.start); verify.renameLocations(/*findInStrings*/ false, /*findInComments*/ false); diff --git a/tests/cases/fourslash/renameParameterPropertyDeclaration3.ts b/tests/cases/fourslash/renameParameterPropertyDeclaration3.ts index 2ca284f38d9..9446e2aeb75 100644 --- a/tests/cases/fourslash/renameParameterPropertyDeclaration3.ts +++ b/tests/cases/fourslash/renameParameterPropertyDeclaration3.ts @@ -8,7 +8,7 @@ //// } let ranges = test.ranges(); -verify.assertRangesEmpty(ranges); +verify.assertHasRanges(ranges); for (let range of ranges) { goTo.position(range.start); verify.renameLocations(/*findInStrings*/ false, /*findInComments*/ false); diff --git a/tests/cases/fourslash/renameParameterPropertyDeclaration4.ts b/tests/cases/fourslash/renameParameterPropertyDeclaration4.ts index 35d268532b9..7fb4b8c757d 100644 --- a/tests/cases/fourslash/renameParameterPropertyDeclaration4.ts +++ b/tests/cases/fourslash/renameParameterPropertyDeclaration4.ts @@ -7,7 +7,7 @@ //// } let ranges = test.ranges(); -verify.assertRangesEmpty(ranges); +verify.assertHasRanges(ranges); for (let range of ranges) { goTo.position(range.start); verify.renameLocations(/*findInStrings*/ false, /*findInComments*/ false); diff --git a/tests/cases/fourslash/renameParameterPropertyDeclaration5.ts b/tests/cases/fourslash/renameParameterPropertyDeclaration5.ts index d32e69ad0c5..b7c47a4c0d7 100644 --- a/tests/cases/fourslash/renameParameterPropertyDeclaration5.ts +++ b/tests/cases/fourslash/renameParameterPropertyDeclaration5.ts @@ -7,7 +7,7 @@ //// } let ranges = test.ranges(); -verify.assertRangesEmpty(ranges); +verify.assertHasRanges(ranges); for (let range of ranges) { goTo.position(range.start); verify.renameLocations(/*findInStrings*/ false, /*findInComments*/ false);