From 77164e1eb9024a714cf2406adab9fc33a6235cd2 Mon Sep 17 00:00:00 2001 From: TravCav Date: Thu, 5 Apr 2018 12:58:42 -0400 Subject: [PATCH 1/3] redundant code --- src/compiler/checker.ts | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts index 4f3419a0e9a..8fee90764ce 100644 --- a/src/compiler/checker.ts +++ b/src/compiler/checker.ts @@ -24749,8 +24749,6 @@ namespace ts { case SyntaxKind.ExportAssignment: return checkExportAssignment(node); case SyntaxKind.EmptyStatement: - checkGrammarStatementInAmbientContext(node); - return; case SyntaxKind.DebuggerStatement: checkGrammarStatementInAmbientContext(node); return; From 60bd7e861ca3951b315f61170c4a60d8625c943b Mon Sep 17 00:00:00 2001 From: TravCav Date: Fri, 6 Apr 2018 12:23:41 -0400 Subject: [PATCH 2/3] removed always true condition --- src/compiler/moduleNameResolver.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/moduleNameResolver.ts b/src/compiler/moduleNameResolver.ts index a203b2bfaba..c8845e7ad35 100644 --- a/src/compiler/moduleNameResolver.ts +++ b/src/compiler/moduleNameResolver.ts @@ -1034,7 +1034,7 @@ namespace ts { const onlyRecordFailures = !directoryProbablyExists(getDirectoryPath(file), state.host); const fromFile = tryFile(file, failedLookupLocations, onlyRecordFailures, state); if (fromFile) { - const resolved = fromFile && resolvedIfExtensionMatches(extensions, fromFile); + const resolved = resolvedIfExtensionMatches(extensions, fromFile); if (resolved) { return resolved; } From 9861569ae977297319158b35f3181e047a5e5527 Mon Sep 17 00:00:00 2001 From: TravCav Date: Fri, 6 Apr 2018 13:40:58 -0400 Subject: [PATCH 3/3] found another place to fall through in the checker --- src/compiler/checker.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts index 8fee90764ce..6d083d07385 100644 --- a/src/compiler/checker.ts +++ b/src/compiler/checker.ts @@ -24629,7 +24629,6 @@ namespace ts { case SyntaxKind.ConstructorType: case SyntaxKind.CallSignature: case SyntaxKind.ConstructSignature: - return checkSignatureDeclaration(node); case SyntaxKind.IndexSignature: return checkSignatureDeclaration(node); case SyntaxKind.MethodDeclaration: