From 70944428a1a347274afe5052bd8b0d7adc19c72f Mon Sep 17 00:00:00 2001 From: Sheetal Nandi Date: Tue, 6 Mar 2018 11:03:20 -0800 Subject: [PATCH] =?UTF-8?q?Create=20the=20action=20only=20if=20the=20text?= =?UTF-8?q?=20change=20creation=20is=20successful.=20=20=E2=80=A6=20Make?= =?UTF-8?q?=20change=20for=20the=20infer=20type=20from=20usage=20could=20r?= =?UTF-8?q?eturn=20undefined=20even=20if=20type=20is=20present=20if=20the?= =?UTF-8?q?=20type=20cannot=20be=20named=20Fixes=20#22184?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/services/codefixes/inferFromUsage.ts | 3 ++- .../codeFixInferFromUsageSetterWithInaccessibleType.ts | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/services/codefixes/inferFromUsage.ts b/src/services/codefixes/inferFromUsage.ts index b5a9e15f5a4..18df488e979 100644 --- a/src/services/codefixes/inferFromUsage.ts +++ b/src/services/codefixes/inferFromUsage.ts @@ -186,7 +186,8 @@ namespace ts.codefix { } function makeFix(declaration: Declaration, start: number, type: Type | undefined, program: Program): Fix | undefined { - return type && { declaration, textChanges: [makeChange(declaration, start, type, program)] }; + const change = makeChange(declaration, start, type, program); + return change && { declaration, textChanges: [change] }; } function makeChange(declaration: Declaration, start: number, type: Type | undefined, program: Program): TextChange | undefined { diff --git a/tests/cases/fourslash/codeFixInferFromUsageSetterWithInaccessibleType.ts b/tests/cases/fourslash/codeFixInferFromUsageSetterWithInaccessibleType.ts index 993a58e8e8e..96c76a64837 100644 --- a/tests/cases/fourslash/codeFixInferFromUsageSetterWithInaccessibleType.ts +++ b/tests/cases/fourslash/codeFixInferFromUsageSetterWithInaccessibleType.ts @@ -13,4 +13,4 @@ ////} goTo.file("/b.ts"); -verify.codeFixAvailable(); \ No newline at end of file +verify.not.codeFixAvailable(); \ No newline at end of file