microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2025-12-11 09:24:19 -06:00
Code Issues Packages Projects Releases 212 Wiki Activity

Fix flow node improper reuse (#60662)

Browse Source
This commit is contained in:
Gabriela Araujo Britto 2024-12-04 09:13:13 -08:00 committed by GitHub
parent 9bf5aa7fe2
commit 6b1ea96b94
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/compiler/binder.ts
View File

@ -21,6 +21,7 @@ import {
BreakOrContinueStatement,
CallChain,
CallExpression,
canHaveFlowNode,
canHaveLocals,
canHaveSymbol,
CaseBlock,
@ -1104,6 +1105,9 @@ function createBinder(): (file: SourceFile, options: CompilerOptions) => void {
// and set it before we descend into nodes that could actually be part of an assignment pattern.
inAssignmentPattern = false;
if (checkUnreachable(node)) {
if (canHaveFlowNode(node) && node.flowNode) {
node.flowNode = undefined;
}
bindEachChild(node);
bindJSDoc(node);
inAssignmentPattern = saveInAssignmentPattern;

13
tests/cases/fourslash/unreachableStatementNodeReuse.ts Normal file
View File

@ -0,0 +1,13 @@
/// <reference path="fourslash.ts" />
//// function test() {
//// return/*a*/abc();
//// return;
//// }
//// function abc() { }
verify.numberOfErrorsInCurrentFile(1);
goTo.marker("a")
edit.insert(" ");
verify.noErrors();