microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-02-06 20:14:01 -06:00
Code Issues Packages Projects Releases 212 Wiki Activity

Better check for right.text, more comments in test

Browse Source
This commit is contained in:
Oleg Mihailik 2017-02-26 23:13:50 +00:00
parent 27675fc96e
commit 6a88cf0edf
2 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/compiler/checker.ts
View File

@ -15929,12 +15929,16 @@ namespace ts {
checkAssignmentOperator(rightType);
return getRegularTypeOfObjectLiteral(rightType);
case SyntaxKind.CommaToken:
if (!compilerOptions.allowUnreachableCode && isSideEffectFree(left) && right.text!=="eval") {
if (!compilerOptions.allowUnreachableCode && isSideEffectFree(left) && !isEvalNode(right)) {
error(left, Diagnostics.Left_side_of_comma_operator_is_unused_and_has_no_side_effects);
}
return rightType;
}
function isEvalNode(node: Expression) {
return node.kind === SyntaxKind.Identifier && (node as Identifier).text === "eval";
}
// Return true if there was no error, false if there was an error.
function checkForDisallowedESSymbolOperand(operator: SyntaxKind): boolean {
const offendingSymbolOperand =

4
tests/cases/compiler/evalAfter0.ts
View File

@ -1,3 +1,3 @@
(0,eval)("10");
(0,eval)("10"); // fine: special case for eval
(0,alert)("10");
(0,alert)("10"); // error: no side effect left of comma (suspect of missing method name or something)