Addressing CR feedback + Run fourslash tests with ES5 emit

This commit is contained in:
Anders Hejlsberg 2014-12-15 15:16:54 -08:00
parent b9db747117
commit 667e82fba2
2 changed files with 6 additions and 2 deletions

View File

@ -2313,6 +2313,7 @@ module ts {
var pos = 0;
var group = 0;
while (pos < length) {
// Emit using the pattern <group0>.concat(<group1>, <group2>, ...)
if (group === 1) {
write(".concat(");
}
@ -2326,7 +2327,10 @@ module ts {
pos++;
}
else {
for (var i = pos; i < length && elements[i].kind !== SyntaxKind.SpreadElementExpression; i++);
var i = pos;
while (i < length && elements[i].kind !== SyntaxKind.SpreadElementExpression) {
i++;
}
write("[");
emitList(elements, pos, i - pos, /*multiLine*/ (node.flags & NodeFlags.MultiLine) !== 0,
/*trailingComma*/ elements.hasTrailingComma);

View File

@ -146,7 +146,7 @@ module FourSlash {
testOptMetadataNames.outDir, testOptMetadataNames.sourceMap, testOptMetadataNames.sourceRoot]
function convertGlobalOptionsToCompilerOptions(globalOptions: { [idx: string]: string }): ts.CompilerOptions {
var settings: ts.CompilerOptions = {};
var settings: ts.CompilerOptions = { target: ts.ScriptTarget.ES5 };
// Convert all property in globalOptions into ts.CompilationSettings
for (var prop in globalOptions) {
if (globalOptions.hasOwnProperty(prop)) {