From 657b3e00ee69d6d4a164ff3ebe3b6dc94df0a6d2 Mon Sep 17 00:00:00 2001 From: Daniel Rosenwasser Date: Tue, 5 Feb 2019 17:37:21 -0800 Subject: [PATCH] Move assignment to error span reset, and give some explanation. --- src/compiler/checker.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts index 7641322d040..9e2ab97e45c 100644 --- a/src/compiler/checker.ts +++ b/src/compiler/checker.ts @@ -12234,7 +12234,12 @@ namespace ts { const propDeclaration = prop.valueDeclaration as ObjectLiteralElementLike; Debug.assertNode(propDeclaration, isObjectLiteralElementLike); + // Give a specific error message span on the property declaration, and signal + // to the rest of the relationship check not to provide the trail of context. + // We don't want to overwhelm our users with the context, and hopefully they + // already have enough information to piece this together. errorNode = propDeclaration; + shouldConstructDiagnosticTrail = false; const name = propDeclaration.name!; if (isIdentifier(name)) { @@ -12250,7 +12255,6 @@ namespace ts { reportError(Diagnostics.Object_literal_may_only_specify_known_properties_and_0_does_not_exist_in_type_1, symbolToString(prop), typeToString(errorTarget)); } - shouldConstructDiagnosticTrail = false; } } return true;