prefer-const

This commit is contained in:
Alexander T
2019-06-19 17:58:49 +03:00
parent 504b932f7b
commit 5ce8c831b4
16 changed files with 50 additions and 53 deletions

View File

@@ -73,7 +73,7 @@ function getKnownAuthorMaps() {
}
function deduplicate<T>(array: T[]): T[] {
let result: T[] = [];
const result: T[] = [];
if (array) {
for (const item of array) {
if (result.indexOf(item) < 0) {

View File

@@ -42,7 +42,7 @@ class DeclarationsWalker {
return;
}
this.visitedTypes.push(type);
let s = type.aliasSymbol || type.getSymbol();
const s = type.aliasSymbol || type.getSymbol();
if (!s) {
return;
}
@@ -64,7 +64,7 @@ class DeclarationsWalker {
}
else {
// splice declaration in final d.ts file
let text = decl.getFullText();
const text = decl.getFullText();
this.text += `${text}\n`;
// recursively pull all dependencies into result dts file

View File

@@ -1,35 +1,35 @@
declare var require: any;
let fs = require("fs");
let async = require("async");
let glob = require("glob");
const fs = require("fs");
const async = require("async");
const glob = require("glob");
fs.readFile("src/compiler/diagnosticMessages.json", "utf-8", (err, data) => {
if (err) {
throw err;
}
let messages = JSON.parse(data);
let keys = Object.keys(messages);
const messages = JSON.parse(data);
const keys = Object.keys(messages);
console.log("Loaded " + keys.length + " errors");
for (let k of keys) {
for (const k of keys) {
messages[k].seen = false;
}
let errRegex = /\(\d+,\d+\): error TS([^:]+):/g;
const errRegex = /\(\d+,\d+\): error TS([^:]+):/g;
const baseDir = "tests/baselines/reference/";
let baseDir = "tests/baselines/reference/";
fs.readdir(baseDir, (err, files) => {
files = files.filter(f => f.indexOf(".errors.txt") > 0);
let tasks: Array<(callback: () => void) => void> = [];
const tasks: Array<(callback: () => void) => void> = [];
files.forEach(f => tasks.push(done => {
fs.readFile(baseDir + f, "utf-8", (err, baseline) => {
if (err) throw err;
let g: string[];
while (g = errRegex.exec(baseline)) {
var errCode = +g[1];
let msg = keys.filter(k => messages[k].code === errCode)[0];
const errCode = +g[1];
const msg = keys.filter(k => messages[k].code === errCode)[0];
messages[msg].seen = true;
}
@@ -40,7 +40,7 @@ fs.readFile("src/compiler/diagnosticMessages.json", "utf-8", (err, data) => {
async.parallelLimit(tasks, 25, done => {
console.log("== List of errors not present in baselines ==");
let count = 0;
for (let k of keys) {
for (const k of keys) {
if (messages[k].seen !== true) {
console.log(k);
count++;
@@ -52,8 +52,8 @@ fs.readFile("src/compiler/diagnosticMessages.json", "utf-8", (err, data) => {
});
fs.readFile("src/compiler/diagnosticInformationMap.generated.ts", "utf-8", (err, data) => {
let errorRegexp = /\s(\w+): \{ code/g;
let errorNames: string[] = [];
const errorRegexp = /\s(\w+): \{ code/g;
const errorNames: string[] = [];
let errMatch: string[];
while (errMatch = errorRegexp.exec(data)) {
errorNames.push(errMatch[1]);
@@ -62,12 +62,12 @@ fs.readFile("src/compiler/diagnosticInformationMap.generated.ts", "utf-8", (err,
let allSrc = "";
glob("./src/**/*.ts", {}, (err, files) => {
console.log("Reading " + files.length + " source files");
for (let file of files) {
for (const file of files) {
if (file.indexOf("diagnosticInformationMap.generated.ts") > 0) {
continue;
}
let src = fs.readFileSync(file, "utf-8");
const src = fs.readFileSync(file, "utf-8");
allSrc = allSrc + src;
}
@@ -75,7 +75,7 @@ fs.readFile("src/compiler/diagnosticInformationMap.generated.ts", "utf-8", (err,
let count = 0;
console.log("== List of errors not used in source ==");
for (let errName of errorNames) {
for (const errName of errorNames) {
if (allSrc.indexOf(errName) < 0) {
console.log(errName);
count++;

View File

@@ -42,7 +42,7 @@ function filePathEndsWith(path: string, endingString: string): boolean {
}
function copyFileSync(source: string, destination: string) {
let text = fs.readFileSync(source);
const text = fs.readFileSync(source);
fs.writeFileSync(destination, text);
}
@@ -52,8 +52,8 @@ function importDefinitelyTypedTest(tscPath: string, rwcTestPath: string, testCas
cmd += " @" + responseFile;
}
let testDirectoryName = testCaseName + "_" + Math.floor((Math.random() * 10000) + 1);
let testDirectoryPath = path.join(process.env.temp, testDirectoryName);
const testDirectoryName = testCaseName + "_" + Math.floor((Math.random() * 10000) + 1);
const testDirectoryPath = path.join(process.env.temp, testDirectoryName);
if (fs.existsSync(testDirectoryPath)) {
throw new Error("Could not create test directory");
}
@@ -77,8 +77,8 @@ function importDefinitelyTypedTest(tscPath: string, rwcTestPath: string, testCas
}
// copy generated file to output location
let outputFilePath = path.join(testDirectoryPath, "iocapture0.json");
let testCasePath = path.join(rwcTestPath, "DefinitelyTyped_" + testCaseName + ".json");
const outputFilePath = path.join(testDirectoryPath, "iocapture0.json");
const testCasePath = path.join(rwcTestPath, "DefinitelyTyped_" + testCaseName + ".json");
copyFileSync(outputFilePath, testCasePath);
//console.log("output generated at: " + outputFilePath);
@@ -121,8 +121,8 @@ function importDefinitelyTypedTests(tscPath: string, rwcTestPath: string, defini
throw err;
}
let tsFiles: string[] = [];
let testFiles: string[] = [];
const tsFiles: string[] = [];
const testFiles: string[] = [];
let paramFile: string;
for (const filePath of files.map(f => path.join(directoryPath, f))) {