From 782239b6b14d6827e9098eb3c3d9bfb8d6c254d4 Mon Sep 17 00:00:00 2001 From: Cyrus Najmabadi Date: Wed, 29 Oct 2014 14:18:29 -0700 Subject: [PATCH] use .pop() on an array instead of setting the length directly. The latter causes v8 to stop optimizing the method. --- src/services/syntax/scanner.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/services/syntax/scanner.ts b/src/services/syntax/scanner.ts index 29ced029f1c..a30b8b7d4b2 100644 --- a/src/services/syntax/scanner.ts +++ b/src/services/syntax/scanner.ts @@ -1628,13 +1628,12 @@ module TypeScript.Scanner { var diagnostic = _tokenDiagnostics[tokenDiagnosticsLength - 1]; if (diagnostic.start() >= position) { tokenDiagnosticsLength--; + _tokenDiagnostics.pop(); } else { break; } } - - _tokenDiagnostics.length = tokenDiagnosticsLength; } function resetToPosition(absolutePosition: number): void {