microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-05-18 07:29:16 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

Always mark derived constructors as 'this'-capturing.

Browse Source
This commit is contained in:
Daniel Rosenwasser
2016-09-19 18:29:15 +03:00
parent 60bcd7e0d0
commit 5b3a93db2f
1 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/compiler/checker.ts
View File

@@ -9322,11 +9322,6 @@ namespace ts {
}
}
// Even if 'super' isn't ever actually called, we may need to capture 'this' for a derived class.
if (languageVersion < ScriptTarget.ES6 && container && container.kind === SyntaxKind.Constructor) {
needToCaptureLexicalThis = needToCaptureLexicalThis || !!getClassExtendsHeritageClauseElement(getContainingClass(container));
}
const canUseSuperExpression = isLegalUsageOfSuperExpression(container);
let nodeCheckFlag: NodeCheckFlags = 0;
@@ -14312,6 +14307,7 @@ namespace ts {
// constructors of derived classes must contain at least one super call somewhere in their function body.
const containingClassDecl = <ClassDeclaration>node.parent;
if (getClassExtendsHeritageClauseElement(containingClassDecl)) {
captureLexicalThis(node.parent, containingClassDecl);
const classExtendsNull = classDeclarationExtendsNull(containingClassDecl);
const superCall = getSuperCallInConstructor(node);
if (superCall) {