microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2025-12-12 20:25:48 -06:00
Code Issues Packages Projects Releases 212 Wiki Activity

Merge pull request #14302 from Microsoft/make-special-property-assignment-apply-only-to-lhs

Browse Source 
Provide special property assignment symbol only for left-hand side of assignment
This commit is contained in:
Nathan Shively-Sanders 2017-02-24 15:14:30 -08:00 committed by GitHub
commit 5b23dbc999
3 changed files with 29 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/compiler/checker.ts
View File

@ -20930,7 +20930,9 @@ namespace ts {
return getSymbolOfNode(entityName.parent);
}
if (isInJavaScriptFile(entityName) && entityName.parent.kind === SyntaxKind.PropertyAccessExpression) {
if (isInJavaScriptFile(entityName) &&
entityName.parent.kind === SyntaxKind.PropertyAccessExpression &&
entityName.parent === (entityName.parent.parent as BinaryExpression).left) {
// Check if this is a special property assignment
const specialPropertyAssignmentSymbol = getSpecialPropertyAssignmentSymbolFromEntityName(entityName);
if (specialPropertyAssignmentSymbol) {

13
tests/cases/fourslash/renameJsSpecialAssignmentRhs1.ts Normal file
View File

@ -0,0 +1,13 @@
/// <reference path="fourslash.ts"/>
// @allowJs: true
// @Filename: a.js
////const foo = {
//// set: function (x) {
//// this._x = x;
//// },
//// copy: function ([|x|]) {
//// this._x = /**/[|x|].prop;
//// }
////};
goTo.marker();
verify.renameLocations(/*findInStrings*/ false, /*findInComments*/ false);

13
tests/cases/fourslash/renameJsSpecialAssignmentRhs2.ts Normal file
View File

@ -0,0 +1,13 @@
/// <reference path="fourslash.ts"/>
// @allowJs: true
// @Filename: a.js
////const foo = {
//// set: function (x) {
//// this._x = x;
//// },
//// copy: function (/**/[|x|]) {
//// this._x = [|x|].prop;
//// }
////};
goTo.marker();
verify.renameLocations(/*findInStrings*/ false, /*findInComments*/ false);