microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-02-11 10:00:13 -06:00
Code Issues Packages Projects Releases 212 Wiki Activity

Harden combineProjectOutputForReferences against empty results (#48978)

Browse Source 
Getting an empty result doesn't seem expected, but a deeper fix doesn't make sense until #48619 is merged.

Fixes #48963
This commit is contained in:
Andrew Casey 2022-05-05 13:52:34 -07:00 committed by GitHub
parent 4680b54616
commit 58114cf387
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/server/session.ts
View File

@ -356,7 +356,7 @@ namespace ts.server {
logger.info(`Finding references to ${location.fileName} position ${location.pos} in project ${project.getProjectName()}`);
const projectOutputs = project.getLanguageService().findReferences(location.fileName, location.pos);
if (projectOutputs) {
const clearIsDefinition = projectOutputs[0].references[0].isDefinition === undefined;
const clearIsDefinition = projectOutputs[0]?.references[0]?.isDefinition === undefined;
for (const referencedSymbol of projectOutputs) {
const mappedDefinitionFile = getMappedLocation(project, documentSpanLocation(referencedSymbol.definition));
const definition: ReferencedSymbolDefinitionInfo = mappedDefinitionFile === undefined ?

1
tests/baselines/reference/referencesToNonPropertyNameStringLiteral.baseline.jsonc Normal file
View File

@ -0,0 +1 @@
[]

5
tests/cases/fourslash/server/referencesToNonPropertyNameStringLiteral.ts Normal file
View File

@ -0,0 +1,5 @@
/// <reference path="../fourslash.ts"/>
////const str: string = "hello/*1*/";
verify.baselineFindAllReferences('1')