From 57a6dbd6fa7715e3176339743b30c1de7ed55d73 Mon Sep 17 00:00:00 2001 From: Benjamin Lichtman Date: Fri, 14 Sep 2018 08:50:18 -0700 Subject: [PATCH] Add clarifying comments --- src/services/codefixes/convertToAsyncFunction.ts | 3 ++- src/services/suggestionDiagnostics.ts | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/services/codefixes/convertToAsyncFunction.ts b/src/services/codefixes/convertToAsyncFunction.ts index ba230aa95e4..b12d4daf1c8 100644 --- a/src/services/codefixes/convertToAsyncFunction.ts +++ b/src/services/codefixes/convertToAsyncFunction.ts @@ -393,9 +393,10 @@ namespace ts.codefix { const shouldReturn = transformer.setOfExpressionsToReturn.get(getNodeId(parent).toString()); switch (func.kind) { case SyntaxKind.NullKeyword: - // do not produce a transformed statement for a null or undefined argument + // do not produce a transformed statement for a null argument break; case SyntaxKind.Identifier: + // identifier includes undefined if (!hasArgName) break; const synthCall = createCall(getSynthesizedDeepClone(func) as Identifier, /*typeArguments*/ undefined, [argName.identifier]); diff --git a/src/services/suggestionDiagnostics.ts b/src/services/suggestionDiagnostics.ts index 3df40c8d9df..66360948ea7 100644 --- a/src/services/suggestionDiagnostics.ts +++ b/src/services/suggestionDiagnostics.ts @@ -196,7 +196,7 @@ namespace ts { function isFixablePromiseArgument(arg: Expression): boolean { switch (arg.kind) { case SyntaxKind.NullKeyword: - case SyntaxKind.Identifier: + case SyntaxKind.Identifier: // identifier includes undefined case SyntaxKind.FunctionDeclaration: case SyntaxKind.FunctionExpression: case SyntaxKind.ArrowFunction: