From 4a497fb99451d9231addf87027f57c3eb0d95958 Mon Sep 17 00:00:00 2001 From: Arthur Ozga Date: Wed, 5 Oct 2016 14:53:13 -0700 Subject: [PATCH] update tests to reflect no completion filtering --- ...rStringLiteralRelativeImportAllowJSTrue.ts | 13 ++------- ...ipleSlashRefPathCompletionAbsolutePaths.ts | 2 +- ...ashRefPathCompletionBackandForwardSlash.ts | 6 +--- .../tripleSlashRefPathCompletionContext.ts | 2 +- .../tripleSlashRefPathCompletionNarrowing.ts | 23 ++++----------- ...ipleSlashRefPathCompletionRelativePaths.ts | 29 +++++-------------- 6 files changed, 20 insertions(+), 55 deletions(-) diff --git a/tests/cases/fourslash/completionForStringLiteralRelativeImportAllowJSTrue.ts b/tests/cases/fourslash/completionForStringLiteralRelativeImportAllowJSTrue.ts index 72b6df52b32..6eab9aaeca2 100644 --- a/tests/cases/fourslash/completionForStringLiteralRelativeImportAllowJSTrue.ts +++ b/tests/cases/fourslash/completionForStringLiteralRelativeImportAllowJSTrue.ts @@ -33,7 +33,8 @@ const kinds = ["import_as", "import_equals", "require"]; for (const kind of kinds) { - goTo.marker(kind + "0"); + for(let i = 0; i < 2; ++i) { + goTo.marker(kind + i); verify.completionListContains("f1"); verify.completionListContains("f2"); verify.completionListContains("f3"); @@ -43,13 +44,5 @@ for (const kind of kinds) { verify.completionListContains("g1"); verify.completionListContains("g2"); verify.not.completionListItemsCountIsGreaterThan(8); - - goTo.marker(kind + "1"); - verify.completionListContains("f1"); - verify.completionListContains("f2"); - verify.completionListContains("f3"); - verify.completionListContains("f4"); - verify.completionListContains("f5"); - verify.completionListContains("f6"); - verify.not.completionListItemsCountIsGreaterThan(6); + } } \ No newline at end of file diff --git a/tests/cases/fourslash/tripleSlashRefPathCompletionAbsolutePaths.ts b/tests/cases/fourslash/tripleSlashRefPathCompletionAbsolutePaths.ts index 79e6f7c8b1a..99fffd7a7d6 100644 --- a/tests/cases/fourslash/tripleSlashRefPathCompletionAbsolutePaths.ts +++ b/tests/cases/fourslash/tripleSlashRefPathCompletionAbsolutePaths.ts @@ -1,6 +1,6 @@ /// -// Offers completions for absolute paths. +// Exercises completions for absolute paths. // @Filename: tests/test0.ts //// /// -// Exercises for whether completions are performed depending on where the caret is positioned in the ref comment. +// Exercises whether completions are supplied, conditional on the caret position in the ref comment. // @Filename: f.ts //// /*f*/ diff --git a/tests/cases/fourslash/tripleSlashRefPathCompletionNarrowing.ts b/tests/cases/fourslash/tripleSlashRefPathCompletionNarrowing.ts index 5f43b3033fc..6bf3a1e72e3 100644 --- a/tests/cases/fourslash/tripleSlashRefPathCompletionNarrowing.ts +++ b/tests/cases/fourslash/tripleSlashRefPathCompletionNarrowing.ts @@ -1,7 +1,7 @@ /// -// Exercises relative path completions going up and down 2 directories -// and the use of forward- and back-slashes and combinations thereof. +// Exercises how changes in the basename change the completions offered. +// They should have no effect, as filtering completions is the responsibility of the editor. // @Filename: f1.ts //// /*f1*/ @@ -25,21 +25,10 @@ //// ///