microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-05-29 16:29:19 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

Give a related span pointing to the implementation signature when reporting incompatibility.

Browse Source
This commit is contained in:
Daniel Rosenwasser
2019-02-21 10:42:38 -08:00
parent cee933ff09
commit 4a256abc8a
2 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/compiler/checker.ts
View File

@@ -24448,7 +24448,10 @@ namespace ts {
const bodySignature = getSignatureFromDeclaration(bodyDeclaration);
for (const signature of signatures) {
if (!isImplementationCompatibleWithOverload(bodySignature, signature)) {
error(signature.declaration, Diagnostics.This_overload_signature_is_not_compatible_with_its_implementation_signature);
addRelatedInfo(
error(signature.declaration, Diagnostics.This_overload_signature_is_not_compatible_with_its_implementation_signature),
createDiagnosticForNode(bodyDeclaration, Diagnostics.The_implementation_signature_is_declared_here)
);
break;
}
}

4
src/compiler/diagnosticMessages.json
View File

@@ -2585,6 +2585,10 @@
"category": "Error",
"code": 2749
},
"The implementation signature is declared here.": {
"category": "Error",
"code": 2750
},
"Import declaration '{0}' is using private name '{1}'.": {
"category": "Error",