From 71cbaef79e7e00dfbe42c87bf228793db36fc1b6 Mon Sep 17 00:00:00 2001 From: Mohamed Hegazy Date: Thu, 29 Oct 2015 15:27:45 -0700 Subject: [PATCH 1/4] Update documentation for fixing lib issues --- CONTRIBUTING.md | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 2e2c28590c2..3891b3826ba 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -32,6 +32,19 @@ Your pull request should: * Follow the code conventions descriped in [Coding guidelines](https://github.com/Microsoft/TypeScript/wiki/Coding-guidelines) * To avoid line ending issues, set `autocrlf = input` and `whitespace = cr-at-eol` in your git configuration +## Contributing `lib.d.ts` fixes + +The library sources are in: [src\lib\](https://github.com/Microsoft/TypeScript/tree/master/src/lib) + +To build the library files, run +```Shell +jake lib +``` + +`src\lib\dom.generated.d.ts` and `webworker.generated.d.ts`: + +These two files represent the DOM typings and are auto-generated. To make any modifications to them, please update the generation script in https://github.com/Microsoft/TSJS-lib-generator + ## Running the Tests To run all tests, invoke the `runtests` target using jake: From 0c3d52e8b138fcfc464d3955f31cf41780ae0823 Mon Sep 17 00:00:00 2001 From: Mohamed Hegazy Date: Thu, 29 Oct 2015 17:33:09 -0700 Subject: [PATCH 2/4] Update CONTRIBUTING.md respond to review comments --- CONTRIBUTING.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 3891b3826ba..ebbe2af322a 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -41,9 +41,9 @@ To build the library files, run jake lib ``` -`src\lib\dom.generated.d.ts` and `webworker.generated.d.ts`: +`src\lib\dom.generated.d.ts` and `src\lib\webworker.generated.d.ts`: -These two files represent the DOM typings and are auto-generated. To make any modifications to them, please update the generation script in https://github.com/Microsoft/TSJS-lib-generator +These two files represent the DOM typings and are auto-generated. To make any modifications to them, please submit a PR to https://github.com/Microsoft/TSJS-lib-generator ## Running the Tests From 4a7804337ca1394adc144dfc79aae3a9cbc79aab Mon Sep 17 00:00:00 2001 From: Mohamed Hegazy Date: Mon, 2 Nov 2015 17:07:14 -0800 Subject: [PATCH 3/4] Update CONTRIBUTING.md --- CONTRIBUTING.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index ebbe2af322a..7c1f068920c 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -34,14 +34,14 @@ Your pull request should: ## Contributing `lib.d.ts` fixes -The library sources are in: [src\lib\](https://github.com/Microsoft/TypeScript/tree/master/src/lib) +The library sources are in: [src/lib](https://github.com/Microsoft/TypeScript/tree/master/src/lib) To build the library files, run ```Shell jake lib ``` -`src\lib\dom.generated.d.ts` and `src\lib\webworker.generated.d.ts`: +### `src/lib/dom.generated.d.ts` and `src/lib/webworker.generated.d.ts` These two files represent the DOM typings and are auto-generated. To make any modifications to them, please submit a PR to https://github.com/Microsoft/TSJS-lib-generator From 244b26d762c36e312b8f891dcac4a69703b506bb Mon Sep 17 00:00:00 2001 From: Mohamed Hegazy Date: Mon, 2 Nov 2015 17:08:14 -0800 Subject: [PATCH 4/4] Update CONTRIBUTING.md --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 7c1f068920c..68d88854849 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -41,7 +41,7 @@ To build the library files, run jake lib ``` -### `src/lib/dom.generated.d.ts` and `src/lib/webworker.generated.d.ts` +#### `src/lib/dom.generated.d.ts` and `src/lib/webworker.generated.d.ts` These two files represent the DOM typings and are auto-generated. To make any modifications to them, please submit a PR to https://github.com/Microsoft/TSJS-lib-generator