microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-02-09 20:51:43 -06:00
Code Issues Packages Projects Releases 212 Wiki Activity

fix(43006): skip trivia in a function name (#43021)

Browse Source
This commit is contained in:
Oleksandr T 2021-03-03 02:32:28 +02:00 committed by GitHub
parent 7b14d41642
commit 47b2632ddd
4 changed files with 40 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/services/codefixes/fixAddMissingMember.ts
View File

@ -402,7 +402,7 @@ namespace ts.codefix {
function addFunctionDeclaration(changes: textChanges.ChangeTracker, context: CodeFixContextBase, info: FunctionInfo) {
const importAdder = createImportAdder(context.sourceFile, context.program, context.preferences, context.host);
const functionDeclaration = createSignatureDeclarationFromCallExpression(SyntaxKind.FunctionDeclaration, context, importAdder, info.call, info.token, info.modifierFlags, info.parentDeclaration) as FunctionDeclaration;
const functionDeclaration = createSignatureDeclarationFromCallExpression(SyntaxKind.FunctionDeclaration, context, importAdder, info.call, idText(info.token), info.modifierFlags, info.parentDeclaration) as FunctionDeclaration;
changes.insertNodeAtEndOfScope(info.sourceFile, info.parentDeclaration, functionDeclaration);
}
}

2
src/services/codefixes/helpers.ts
View File

@ -252,7 +252,7 @@ namespace ts.codefix {
context: CodeFixContextBase,
importAdder: ImportAdder,
call: CallExpression,
name: Identifier,
name: Identifier | string,
modifierFlags: ModifierFlags,
contextNode: Node
) {

17
tests/cases/fourslash/codeFixAddMissingFunctionDeclaration17.ts Normal file
View File

@ -0,0 +1,17 @@
/// <reference path='fourslash.ts' />
////// comment
////foo();
verify.codeFix({
index: 0,
description: [ts.Diagnostics.Add_missing_function_declaration_0.message, "foo"],
newFileContent:
`// comment
foo();
function foo() {
throw new Error("Function not implemented.");
}
`
});

21
tests/cases/fourslash/codeFixAddMissingFunctionDeclaration18.ts Normal file
View File

@ -0,0 +1,21 @@
/// <reference path='fourslash.ts' />
/////**
//// * comment
//// */
////foo();
verify.codeFix({
index: 0,
description: [ts.Diagnostics.Add_missing_function_declaration_0.message, "foo"],
newFileContent:
`/**
* comment
*/
foo();
function foo() {
throw new Error("Function not implemented.");
}
`
});