From 4765355e714f445a99dc3498686b290f66c2d853 Mon Sep 17 00:00:00 2001 From: Jake Bailey <5341706+jakebailey@users.noreply.github.com> Date: Fri, 6 May 2022 11:09:42 -0700 Subject: [PATCH] Fix more tests missing 'it' call in 'describe' (#48994) --- src/testRunner/unittests/publicApi.ts | 34 +++++++++++++++------------ 1 file changed, 19 insertions(+), 15 deletions(-) diff --git a/src/testRunner/unittests/publicApi.ts b/src/testRunner/unittests/publicApi.ts index a1e43e7c371..4bfce8288f5 100644 --- a/src/testRunner/unittests/publicApi.ts +++ b/src/testRunner/unittests/publicApi.ts @@ -180,30 +180,34 @@ describe("unittests:: Public APIs:: validateLocaleAndSetLanguage", () => { }); describe("unittests:: Public APIs :: forEachChild of @param comments in JSDoc", () => { - const content = ` + it("finds correct children", () => { + const content = ` /** * @param The {@link TypeReferencesInAedoc}. */ var x `; - const sourceFile = ts.createSourceFile("/file.ts", content, ts.ScriptTarget.ESNext, /*setParentNodes*/ true); - const paramTag = sourceFile.getChildren()[0].getChildren()[0].getChildren()[0].getChildren()[0]; - const kids = paramTag.getChildren(); - const seen: Set = new Set(); - ts.forEachChild(paramTag, n => { - assert.strictEqual(/*actual*/ false, seen.has(n), "Found a duplicate-added child"); - seen.add(n); + const sourceFile = ts.createSourceFile("/file.ts", content, ts.ScriptTarget.ESNext, /*setParentNodes*/ true); + const paramTag = sourceFile.getChildren()[0].getChildren()[0].getChildren()[0].getChildren()[0]; + const kids = paramTag.getChildren(); + const seen: Set = new Set(); + ts.forEachChild(paramTag, n => { + assert.strictEqual(/*actual*/ false, seen.has(n), "Found a duplicate-added child"); + seen.add(n); + }); + assert.equal(5, kids.length); }); - assert.equal(5, kids.length); }); describe("unittests:: Public APIs:: getChild* methods on EndOfFileToken with JSDoc", () => { - const content = ` + it("finds correct children", () => { + const content = ` /** jsdoc comment attached to EndOfFileToken */ `; - const sourceFile = ts.createSourceFile("/file.ts", content, ts.ScriptTarget.ESNext, /*setParentNodes*/ true); - const endOfFileToken = sourceFile.getChildren()[1]; - assert.equal(endOfFileToken.getChildren().length, 1); - assert.equal(endOfFileToken.getChildCount(), 1); - assert.notEqual(endOfFileToken.getChildAt(0), /*expected*/ undefined); + const sourceFile = ts.createSourceFile("/file.ts", content, ts.ScriptTarget.ESNext, /*setParentNodes*/ true); + const endOfFileToken = sourceFile.getChildren()[1]; + assert.equal(endOfFileToken.getChildren().length, 1); + assert.equal(endOfFileToken.getChildCount(), 1); + assert.notEqual(endOfFileToken.getChildAt(0), /*expected*/ undefined); + }); });